]> git.puffer.fish Git - matthieu/frr.git/log
matthieu/frr.git
15 years ago[trivia] Fixed typos in communities text (#334)
Denis Ovsienko [Mon, 1 Jun 2009 16:20:36 +0000 (20:20 +0400)]
[trivia] Fixed typos in communities text (#334)

15 years ago[doc] Stick with quagga.net for consistency (#436)
Denis Ovsienko [Mon, 1 Jun 2009 16:07:46 +0000 (20:07 +0400)]
[doc] Stick with quagga.net for consistency (#436)

15 years ago[bgpd] 64-bit bugfix in community_del_val by Jeremy Jackson <jerj@coplanar.net>
Andrew J. Schorr [Fri, 29 May 2009 13:15:20 +0000 (09:15 -0400)]
[bgpd] 64-bit bugfix in community_del_val by Jeremy Jackson <jerj@coplanar.net>

* bgpd/bgp_community.c: (community_del_val) Fix bug in memcpy that was
  using the wrong size on architectures where a pointer is not 32 bits.

15 years ago[release] Bump version to 0.99.12
Paul Jakma [Fri, 8 May 2009 22:20:19 +0000 (23:20 +0100)]
[release] Bump version to 0.99.12

15 years agoFix bgp ipv4/ipv6 accept handling
Stephen Hemminger [Mon, 25 Aug 2008 00:36:51 +0000 (20:36 -0400)]
Fix bgp ipv4/ipv6 accept handling

When bgp calls getaddrinfo, it gets both ipv6 and ipv4 addresses.
Unless IPV6_ONLY is set on Linux, only the ipv6 bind will succeed,
and the IPV4 connections will come in as mapped connections on the
IPV6 socket.

15 years ago[build] tools/multiple-bgpd.sh should be in 'make dist'
Paul Jakma [Fri, 8 May 2009 21:21:09 +0000 (22:21 +0100)]
[build] tools/multiple-bgpd.sh should be in 'make dist'

16 years ago[bgpd] AS4 bugfix by Chris Caputo <ccaputo@alt.net>
Denis Ovsienko [Thu, 30 Apr 2009 13:16:22 +0000 (17:16 +0400)]
[bgpd] AS4 bugfix by Chris Caputo <ccaputo@alt.net>

* bgpd/bgp_aspath.c: (aspath_make_str_count) "assert (len < str_size)" was
  getting hit under certain 4-byte ASN conditions. New realloc strategy.
* bgpd/bgp_aspath.c: (aspath_key_make) const warning fix.

"%d" -> "%u" 4-byte ASN corrections.  Prevent negative number when ASN is
above 2^31.

16 years agoDmitry Tejblum <tejblum@yandex-team.ru>
Denis Ovsienko [Mon, 13 Apr 2009 16:11:44 +0000 (20:11 +0400)]
Dmitry Tejblum <tejblum@yandex-team.ru>

Don't enable HAVE_BSD_STRUCT_IP_MREQ_HACK for FreeBSD 7.0 and upper,
because OS behaviour has changed.

16 years agoJustified OSPF cost function names and added support for:
Denis Ovsienko [Fri, 10 Apr 2009 14:51:24 +0000 (18:51 +0400)]
Justified OSPF cost function names and added support for:
 ospf cost <1-65535> A.B.C.D
 no ospf cost <1-65535>

16 years ago[lib] Fix timer precision.
Joakim Tjernlund [Mon, 10 Nov 2008 08:33:30 +0000 (09:33 +0100)]
[lib] Fix timer precision.

Whenever a thread adds an timer funcname_thread_add_timer_timeval() gets called
to add the timer. Before adding the timer a quagga_gettimeofday() call
is made to do some time house keeping. However quagga_gettimeofday() only
updates recent_time, not relative_time that is used to calculate
the alarm_time. Replace with quagga_get_relative (NULL)

16 years ago[lib] Move type cast in Fletcher checksum
Joakim Tjernlund [Mon, 17 Nov 2008 10:22:25 +0000 (11:22 +0100)]
[lib] Move type cast in Fletcher checksum

The int type cast should be on the whole expression
passed to the mod operator. Otherwise it won't work
when/if c0/c1 is unsigned.
Making c0/c1 unsigned makes it possible to use 5802
as MODX value.

16 years ago[rpm] some defaults for Fedora are way out of date
Paul Jakma [Sat, 29 Nov 2008 16:42:04 +0000 (16:42 +0000)]
[rpm] some defaults for Fedora are way out of date

* quagga.spec.in: No need to default to accomodate now ancient versions of
  Fedora

16 years ago[lib] fix missing sockunion_normalise_mapped
Paul Jakma [Mon, 24 Nov 2008 22:25:16 +0000 (22:25 +0000)]
[lib] fix missing sockunion_normalise_mapped

* lib/sockunion.c: (sockunion_accept) sockunion needs to be normalised here,
  as it used to before this was moved to a dedicated function..

16 years ago[bgpd] Add 'show bgp views' command
Michael Lambert [Sun, 16 Nov 2008 20:12:04 +0000 (20:12 +0000)]
[bgpd] Add 'show bgp views' command

* bgp_vty.c: (show_bgp_views_cmd) new command to list all defined
  views.
  (with small edits by Paul Jakma)

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[lib] Switch Fletcher checksum back to old ospfd version
Paul Jakma [Sun, 16 Nov 2008 18:34:19 +0000 (18:34 +0000)]
[lib] Switch Fletcher checksum back to old ospfd version

* lib/checksum.c: (fletcher_checksum) Switch the second phase of the checksum
  back to the old ospfd logic.

  The isisd-derived version:

  a) is very hard to follow
  b) had some kind of subtle bug that caused it be wrong when c0=0 and c1=254
     (potentially fixable by doing the mods before adjusting x and y)

  Additionally:

  - explicitely cast expressions using non-internal variables to int, to ensure
    the result is signed.
  - defensively change the length argument to 'size_t', to ensure the code
    works with that argument being unsigned..

  Thanks to Joakim Tjernlund for the investigative work into this bug.

* tests/test-checksum.c: new file to exercise the checksum code.

16 years ago[vtysh] Add commands from zebra_routemap.c to vtysh
Bartek Kania [Sat, 4 Oct 2008 16:12:24 +0000 (17:12 +0100)]
[vtysh] Add commands from zebra_routemap.c to vtysh

* Makefile.am: vtysh should also pull in commands from zebra_routemap.c

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years agoMerge branch 'bgpd/fsm'
Paul Jakma [Thu, 2 Oct 2008 15:27:16 +0000 (16:27 +0100)]
Merge branch 'bgpd/fsm'

16 years ago[release] Bump version to 0.99.11
Paul Jakma [Thu, 2 Oct 2008 08:34:34 +0000 (09:34 +0100)]
[release] Bump version to 0.99.11

16 years ago[bgpd] Fix definition of an rsclient command
Michael Lambert [Wed, 24 Sep 2008 16:23:11 +0000 (17:23 +0100)]
[bgpd] Fix definition of an rsclient command

* bgp_route.c: (show_ip_bgp_view_rsclient_route_cmd) Add the missing "ip"
  to the command string.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[ospfd] Fix SEGV during startup introduced in recent commit
Joakim Tjernlund [Wed, 24 Sep 2008 16:15:48 +0000 (17:15 +0100)]
[ospfd] Fix SEGV during startup introduced in recent commit

* ospfd/ospfd.c: (opsf_if_update) Check if ospf_lookup() returns NULL.
  Fixes bug introduced with recent ospf_network_run changes in
  a49eb30a, where SEGV will happen if not the "router ospf" command has
  been executed before the first interfaces are reported by zebra.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[ospfd] Move passive interface check
Joakim Tjernlund [Wed, 24 Sep 2008 16:03:59 +0000 (17:03 +0100)]
[ospfd] Move passive interface check

* ospf_packet.c: Apply passive check and drop for all packages
  and not just Hellos.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[build] Fix --enable-pie so it can actually be disabled
Paul P Komkoff Jr [Wed, 24 Sep 2008 15:42:35 +0000 (16:42 +0100)]
[build] Fix --enable-pie so it can actually be disabled

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[lib] re-enable conversion of v6mapped INET6 sockunions to regular INET
Paul Jakma [Tue, 9 Sep 2008 20:17:04 +0000 (21:17 +0100)]
[lib] re-enable conversion of v6mapped INET6 sockunions to regular INET

* lib/sockunion.c: Re-enable conversion of v6mapped INET6 sockunions to
  regular INET sockunions, which was disabled in 0df7c9, as it leads to
  failures in sockunion_cmp.
  (sockunion_normalise_mapped) consolidate here
  (sockunion_accept) remove conversion code altogether here - no sockunion
  is created
  (sockunion_get{sockname,peername}) normalise newly created sockunion.

16 years ago[bgpd] Allow accepted peers to progress even if realpeer is in Connect
Paul Jakma [Tue, 9 Sep 2008 16:14:33 +0000 (17:14 +0100)]
[bgpd] Allow accepted peers to progress even if realpeer is in Connect

* bgpd/bgp_packet.c: (bgp_open_receive) Try fix the little race in the FSM,
  where a accept-peer that progress faster than realpeer gets closed down if
  realpeer is still just in Connect, by allowing the realpeer to be
  bgp_stop'ed and doing the regular swapping-of-FSM state.

16 years ago[bgpd] Document the FSM dummy-peer race that sometimes afflicts session setup
Paul Jakma [Sat, 6 Sep 2008 12:09:35 +0000 (13:09 +0100)]
[bgpd] Document the FSM dummy-peer race that sometimes afflicts session setup

* bgp_packet.c: (bgp_open_receive) the accept-peer hack can sometimes
  cause a race between two peers that try to establish sessions to each other,
  causing session setup to fail when it should have succeeded. In the worst
  case, the race can 'loop', causing prolonged failure to establish sessions.

16 years agoMerge branch 'restricted-mode'
Paul Jakma [Thu, 4 Sep 2008 12:52:38 +0000 (13:52 +0100)]
Merge branch 'restricted-mode'

16 years ago[ospfd] Minor enhancements to recent self-host-routes suppression patch
Paul Jakma [Thu, 4 Sep 2008 12:52:07 +0000 (13:52 +0100)]
[ospfd] Minor enhancements to recent self-host-routes suppression patch

* ospf_spf.c: (ospf_spf_process_stubs) Track whether
  parent router vertex is the root, so that the host-route
  suppression logic need only be activated for such vertices.
  Move the actual logic to ospf_intra_add_stub.
* ospf_route.c: (ospf_intra_add_stub) Main test of link moved
  here, notionally more appropriate.

16 years agoMerge commit 'remotes/jocke/delete_ghost_route'
Paul Jakma [Wed, 3 Sep 2008 08:00:44 +0000 (09:00 +0100)]
Merge commit 'remotes/jocke/delete_ghost_route'

16 years agoMerge commit '53d0deceeb855493aa03c59477f8af7f6bb75140'
Paul Jakma [Tue, 2 Sep 2008 20:50:50 +0000 (21:50 +0100)]
Merge commit '53d0deceeb855493aa03c59477f8af7f6bb75140'

16 years ago[ospfd] Restructure opsf_if_update() and ospf_network_run()
Joakim Tjernlund [Tue, 2 Sep 2008 18:06:31 +0000 (19:06 +0100)]
[ospfd] Restructure opsf_if_update() and ospf_network_run()

    Add an struct interface paramenter and adjust the affected
    code accordingly.

    The old code was a mess looping over all interfaces several times
    when one interface was added/changed.

    * ospfd/ospfd.h: Add struct interface parameter to ospf_if_update()
    * ospfd/ospf_zebra.c: Add ifp arg to ospf_if_update() calls.
      (ospf_interface_address_delete) delete ospf_if_update() call,
      redundant as function calls ospf_if_free() itself.
    * ospfd/ospfd.c: (ospf_network_unset) handle deconfiguration here,
      rather than ospf_if_update.
      (ospf_network_run_interface) ospf_network_run, for
      any given interface.
      (ospf_network_run) move guts to previous, and use it.
      (ospf_if_update) Adjust to take struct interface as argument, as
      all callers have a specific ifp in mind.
      Iterate over ifp's connected list and call ospf_network_run_interface
      instead of ospf_network_run, turning this path into O(nm) rather
      than O(n^2).
      Adjust all code dealing with opsf_if_update and ospf_network_run to
      pass the new struct interface * arg.

     (some minor modifications and bug-additions by Paul Jakma).

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years agoMerge commit 'remotes/jocke/ospf_neighbour'; commit 'remotes/jocke/snmp_crosscompile'
Paul Jakma [Mon, 1 Sep 2008 19:19:14 +0000 (20:19 +0100)]
Merge commit 'remotes/jocke/ospf_neighbour'; commit 'remotes/jocke/snmp_crosscompile'

16 years ago[doc] Update HACKING to reflect SCM changes and latest practice
Paul Jakma [Tue, 26 Aug 2008 21:15:03 +0000 (22:15 +0100)]
[doc] Update HACKING to reflect SCM changes and latest practice

16 years agotest
Paul Jakma [Tue, 26 Aug 2008 13:49:40 +0000 (14:49 +0100)]
test

16 years agoRevert "[bgpd] Add 'bgp open-accept' option, to send OPEN immediately on accepted...
Paul Jakma [Tue, 26 Aug 2008 13:33:28 +0000 (14:33 +0100)]
Revert "[bgpd] Add 'bgp open-accept' option, to send OPEN immediately on accepted conns"

Revert commit d664ae1182c29b74b409bc8594b7bd0575e91ce9. An experimental
patch which violates RFC4271 quite badly, but managed to accidently sneak
its way in.

16 years agoSet destination for PtP links to OSPF_ALLSPFROUTERS.
Joakim Tjernlund [Fri, 30 May 2008 14:04:39 +0000 (16:04 +0200)]
Set destination for PtP links to OSPF_ALLSPFROUTERS.

Update ospf_db_desc_send(), ospf_ls_upd_queue_send() and ospf_ls_req_send()
to always use OSPF_ALLSPFROUTERS for PtP links.

See RFC 2328, chap 8.1 for details:

    "The IP destination address for the packet is selected as
     follows.  On physical point-to-point networks, the IP
     destination is always set to the address AllSPFRouters."

Without this, it won't be possible to establish adjacencies on
multiple unnumbered links to the same router.
ChangeLog:
2008-07-25 Joakim Tjernlund <Joakim.Tjernlund@transmode.se>

* ospfd/ospf_packet.c: Set destination for PtP links to
  OSPF_ALLSPFROUTERS.

16 years agoIgnore host routes to self.
Joakim Tjernlund [Wed, 20 Aug 2008 12:24:39 +0000 (14:24 +0200)]
Ignore host routes to self.

PtP links with /32 masks adds host routes to the remote host,
see RFC 2328, 12.4.1.1, Option 1.
Make sure that such routes are ignored

16 years agoMake --enable-snmp cross compile and make libcrypto optional with --without-crypto
Joakim Tjernlund [Tue, 13 May 2008 18:03:32 +0000 (20:03 +0200)]
Make --enable-snmp cross compile and make libcrypto optional with --without-crypto

Autoconfig work by me, the rest was done by
"Kirill K. Smirnov" <lich@math.spbu.ru>

16 years agoFix SEGV in ip ospf neighbor all
Joakim Tjernlund [Tue, 1 Jul 2008 14:54:07 +0000 (16:54 +0200)]
Fix SEGV in ip ospf neighbor all

Dont use vty->index in show_ip_ospf_neighbor_all_cmd(),
It is invalid, use ospf_lookup() instead.

16 years ago[vty] Add support for a 'restricted mode' with anonymous vty connections
Paul Jakma [Sat, 23 Aug 2008 13:27:06 +0000 (14:27 +0100)]
[vty] Add support for a 'restricted mode' with anonymous vty connections

* lib/command.h: Add a RESTRICTED_NODE, intended for use with
  anonymous, 'no login' vtys, to provide a subset of 'view' mode
  commands.
* lib/command.c: Add RESTRICTED_NODE bits, nothing special, just
  following VIEW_NODE.
* lib/vty.c: (vty_auth) enable authentication should fall back to
  restricted/view node as appropriate.
  (vty_create) init vty's to restricted/view node as appropriate,
  for the 'no login' case.
  (vty_{no_,}restricted_mode_cmd) config commands to enable
  'anonymous restricted' in vty configuration.
  (vty_config_write) 'anonymous restricted' config.
  (vty_init) Install some commands to restricted mode, and the
  'anonymous restricted' config commands into VTY_NODE.
* bgpd/*.c: Install some of the safe(r) BGP commands into
  'restricted mode', i.e. lookup commands of non-sensitive data.
  Useful with looking-glass route-servers.

16 years ago[trivia] Make 'make dist' happy about ChangeLog expunge
Paul Jakma [Sat, 23 Aug 2008 07:36:42 +0000 (08:36 +0100)]
[trivia] Make 'make dist' happy about ChangeLog expunge

* ChangeLog: Add back a dummy, top-level ChangeLog
* m4/Makefile.am: remove ChangeLog from EXTRA_DIST, why it was
  listed there, who knows.

16 years ago[administrivia] Update gitignore files
Paul Jakma [Wed, 21 Mar 2007 12:41:22 +0000 (12:41 +0000)]
[administrivia] Update gitignore files

- Add more stuff, archive libraries, etc..

16 years ago[administrivia] Git should ignore backup files and .loT files
Paul Jakma [Sat, 21 Oct 2006 17:35:27 +0000 (18:35 +0100)]
[administrivia] Git should ignore backup files and .loT files

16 years ago[trivia] Remove ChangeLog files, as this data is now maintained in SCM
Paul Jakma [Tue, 19 Aug 2008 13:13:43 +0000 (14:13 +0100)]
[trivia] Remove ChangeLog files, as this data is now maintained in SCM

16 years ago[zebra] trivial: fix spelling mistake
Stephen Hemminger [Sun, 17 Aug 2008 17:08:24 +0000 (18:08 +0100)]
[zebra] trivial: fix spelling mistake

16 years ago[bgpd] remove useless check and return in bgp_config_write_damp
Stephen Hemminger [Sun, 17 Aug 2008 16:51:47 +0000 (17:51 +0100)]
[bgpd] remove useless check and return in bgp_config_write_damp

2008-08-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* bgp_damp.?: (bgp_config_write_damp) remove useless check
  of statically allocated config storage, and useless return
  value

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra] trivia: static qualifiers for metaq
Stephen Hemminger [Sun, 17 Aug 2008 16:44:47 +0000 (17:44 +0100)]
[zebra] trivia: static qualifiers for metaq

2008-08-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra_rib.c: (process_subq) mark static
  (rib_meta_queue_add) ditto
  (meta_queue_new) ditt

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra] make some data local
Stephen Hemminger [Sun, 17 Aug 2008 16:41:37 +0000 (17:41 +0100)]
[zebra] make some data local

2008-06-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra_rib.c: static qualifier on local data

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra] ignore dead routes in RIB update
Stephen Hemminger [Sun, 17 Aug 2008 16:39:31 +0000 (17:39 +0100)]
[zebra] ignore dead routes in RIB update

2008-08-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra_rib.c: When doing a RIB update, routes in process of removal
  should be ignored. This fixes bugs where a route is removed but a
  recursive route is not changed.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:linux] netlink: no need to change privs for receive
Stephen Hemminger [Sun, 17 Aug 2008 16:01:44 +0000 (17:01 +0100)]
[zebra:linux] netlink: no need to change privs for receive

2008-06-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* rt_netlink.c: (netlink_parse_info) Linux doesn't check privledges
  on receive, so avoid the overhead of lowering and raising the
  priviledges on each received message

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:linux] netlink: quiet harmless errors
Stephen Hemminger [Sun, 17 Aug 2008 15:56:15 +0000 (16:56 +0100)]
[zebra:linux] netlink: quiet harmless errors

2008-06-17 Stephen Hemminger <stephen.hemminger@vyatta.com>

* rt_netlink.c: (netlink_parse_info) There can be harmless races
  such as adding an existing route, or deleting an already deleted
  route. Don't bother logging these unless debugging is turned on.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:linux] netlink buffer size tweaking only needed on receive socket
Stephen Hemminger [Sat, 16 Aug 2008 17:25:47 +0000 (18:25 +0100)]
[zebra:linux] netlink buffer size tweaking only needed on receive socket

2008-08-16 Stephen Hemminger <stephen.hemminger@vyatta.com>

* rt_netlink.c: (netlink_recvbuf) consolidate recvbuf setting
  (netlink_socket) no need to set receive buffer on netlink sockets
  generally
  (kernel_init) set recvbuffer on the listen socket

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[build] Linux netlink doesn't need IF_PROC
Stephen Hemminger [Sat, 16 Aug 2008 17:03:44 +0000 (18:03 +0100)]
[build] Linux netlink doesn't need IF_PROC

2008-08-16 Stephen Hemminger <stephen.hemminger@vyatta.com>

* configure.ac: If netlink is available, then that is how the
initial routes and interfaces should be read, rather than through
/proc, so don't set IF_PROC.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:linux] clean up blocking setting of netlink sockets
Stephen Hemminger [Sat, 16 Aug 2008 16:51:27 +0000 (17:51 +0100)]
[zebra:linux] clean up blocking setting of netlink sockets

2008-08-16 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra/rt_netlink.c: This change removes the overhead of twiddling
          the socket twice on every route change. The netlink support has
          two sockets, one is used for request/response and should always
          block. The other is used for asynchronous notification and should
          always be non-blocking.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:linux] Filter out unwanted netlink messages by PID
Stephen Hemminger [Sat, 16 Aug 2008 16:30:39 +0000 (17:30 +0100)]
[zebra:linux] Filter out unwanted netlink messages by PID

2008-08-16 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra/rt_netlink.c: Update the netlink socket BPF to cancel out
  unwanted ACKs on the listen socket by matching on the PID.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[warnings] Fix various SOS warnings
Paul Jakma [Fri, 15 Aug 2008 13:05:22 +0000 (14:05 +0100)]
[warnings] Fix various SOS warnings

2008-08-15 Paul Jakma <paul.jakma@sun.com>

* */*: Fix various problems flagged by Sun Studio compiler.
  - '<qualifier> <storage>' obsolescent in declarations
  - empty statements (';' after ALIAS definitions)
  - implicit declarations (e.g printstack in lib/log.c)
  - "\%" in printf string instead of "%%"
  - loops that return on the first iteration (legitimately, but
      compiler can't really know), e.g. bgp_routemap.c
    - internal declarations which mask prototypes.

16 years ago[lib] Fix mistake in tcp-md5sig commit which broke compile on BSD
Paul Jakma [Fri, 15 Aug 2008 13:05:08 +0000 (14:05 +0100)]
[lib] Fix mistake in tcp-md5sig commit which broke compile on BSD

2008-08-15 Paul Jakma <paul.jakma@sun.com>

* lib/sockopt.c: (sockopt_tcp_signature) ifdef'ing hid variable
  declaration for HAVE_DECL_TCP_MD5SIG && !GNU_LINUX, breaking
  compile - fix.

16 years ago[trivia] finish off static'ification of ospf6d and ripngd
Paul Jakma [Fri, 15 Aug 2008 12:45:30 +0000 (13:45 +0100)]
[trivia] finish off static'ification of ospf6d and ripngd

2008-08-15 Paul Jakma <paul.jakma@sun.com>

* {ospf6d,ripngd}/*: Finish job of marking functions as static, or
  exporting declarations for them, to quell warning noise with
  Quagga's GCC default high-level of warning flags. Thus allowing
  remaining, more useful warnings to be more easily seen.

16 years ago[lib] mes_lookup string lookup table argument should be marked const
Stephen Hemminger [Thu, 14 Aug 2008 16:59:25 +0000 (17:59 +0100)]
[lib] mes_lookup string lookup table argument should be marked const

2008-08-14 Stephen Hemminger <stephen.hemminger@vyatta.com>

* lib/log.{c,h}: struct message argument should point to const
* */*.c: adjust to suit,

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[trivia] ignore automake generated 'compile' file
Paul Jakma [Thu, 14 Aug 2008 16:04:57 +0000 (17:04 +0100)]
[trivia] ignore automake generated 'compile' file

16 years ago[zebra] mark some rt_netlink functions static
Stephen Hemminger [Thu, 14 Aug 2008 15:52:26 +0000 (16:52 +0100)]
[zebra] mark some rt_netlink functions static

2008-08-14 Stephen Hemminger <stephen.hemminger@vyatta.com>

* zebra/rt_netlink.c: local functions should be static.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[lib] hash compare function arguments ought to be const qualified
Stephen Hemminger [Thu, 14 Aug 2008 15:25:25 +0000 (16:25 +0100)]
[lib] hash compare function arguments ought to be const qualified

2008-08-14 Stephen Hemminger <stephen.hemminger@vyatta.com>

* lib/hash.h: (struct hash) Hash comparator callback really
  ought to treat storage behind arguments as constant - a compare
  function with side-effects would be evil.
* */*.c: Adjust comparator functions similarly, thus fixing at least
  a few compiler warnings about const qualifier being dropped.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[ospfd] Default route needs to be refreshed after neighbour state change
Daniel Ng [Wed, 13 Aug 2008 19:37:52 +0000 (20:37 +0100)]
[ospfd] Default route needs to be refreshed after neighbour state change

2008-08-13 Daniel Ng <daniel_ng11@lycos.com>

* ospf_nsm.c: (nsm_change_state) Refresh default route on
  state change - a hack, but it works.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[isisd:DLPI] Try open vanity-named DLPI dev before style 1,2
Jingjing Duan [Wed, 13 Aug 2008 18:29:47 +0000 (19:29 +0100)]
[isisd:DLPI] Try open vanity-named DLPI dev before style 1,2

2008-08-13 Jingjing Duan <Jingjing.Duan@sun.com>

* isisd/isis_dlpi.c: (open_dlpi_dev) Clearview-UV device nodes are
  under /dev/net, try opening there before attempting style 1 or 2
  names.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[ospfd/isisd] Switch to lib/ Fletcher checksum, fixing bug in isisd
Jingjing Duan [Wed, 13 Aug 2008 18:09:10 +0000 (19:09 +0100)]
[ospfd/isisd] Switch to lib/ Fletcher checksum, fixing bug in isisd

2008-08-13 Jingjing Duan <Jingjing.Duan@sun.com>

* ospfd/: Remove the old checksum implementation and
  use the consolidated version.
* isisd/: ditto, thus fixing isisd checksuming on big-endian.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[isisd] Fix packet filtering with DLPI
Jingjing Duan [Wed, 13 Aug 2008 18:06:16 +0000 (19:06 +0100)]
[isisd] Fix packet filtering with DLPI

2008-08-13 Jingjing Duan <Jingjing.Duan@sun.com>

* isisd/isis_dlpi.c: Change ioctl from PFIOCSETF (transparent mode)
  to I_STR (non-transparent mode). The old code resulted in no
  filtering at all.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[lib] Add fletcher checksum implementation
Jingjing Duan [Wed, 13 Aug 2008 18:02:03 +0000 (19:02 +0100)]
[lib] Add fletcher checksum implementation

2008-08-13 Jingjing Duan <Jingjing.Duan@sun.com>

* lib/checksum.?: (fletcher_checksum) implementation of
  Fletcher checksum, as per RFC1008.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[zebra:netlink] Set proto/scope on all route update messages
Timo Teräs [Wed, 13 Aug 2008 16:37:14 +0000 (17:37 +0100)]
[zebra:netlink] Set proto/scope on all route update messages

2008-08-13 Timo Teräs <timo.teras@iki.fi>

* zebra/rt_netlink.c: (netlink_route{,_multipath) Set protocol and
  scope appropriately for both NEW and DELROUTE messages, to avoid
  wiping out non-zebra routes on delete.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[vty] Allow delete during password entry
Roy [Wed, 13 Aug 2008 16:27:38 +0000 (17:27 +0100)]
[vty] Allow delete during password entry

2008-08-13 roy <quagga@de.vio.us>

* lib/vty.c: (vty_delete_char) move check for authentication
  down a bit, so we do the delete, but still not re-write of line.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[build] --enable...user/group didn't match help text
Paul P Komkoff Jr [Wed, 13 Aug 2008 15:56:05 +0000 (16:56 +0100)]
[build] --enable...user/group didn't match help text

2008-08-13 Paul P Komkoff Jr <i@stingr.net>

* configure.ac: fix AC_ARG_ENABLE argument to match help string,

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[build] Test for GNU-style PIE support in toolchain and enable
Paul P Komkoff Jr [Wed, 13 Aug 2008 15:17:04 +0000 (16:17 +0100)]
[build] Test for GNU-style PIE support in toolchain and enable

2008-08-13 Paul P Komkoff Jr <i@stingr.net>

* configure.ac: add a configure flag and autoconf macro, which will
  determine if your toolchain supports PIE.
* */Makefile.am: add corresponding CFLAGS and LDFLAGS into
  appropriate places.

Signed-off-by: Paul Jakma <paul@quagga.net>
16 years ago[bgpd] Add 'bgp open-accept' option, to send OPEN immediately on accepted conns
Paul Jakma [Fri, 31 Aug 2007 13:27:37 +0000 (14:27 +0100)]
[bgpd] Add 'bgp open-accept' option, to send OPEN immediately on accepted conns

2007-08-31 Paul Jakma <paul.jakma@sun.com>

* (general) Add 'bgp open-accept' option, to allow bgpd to send OPEN
  on accepted connections, i.e. to not wait till after
  collision-detect to send OPEN, which appears to be allowed in
  RFC4271. This may help speed up establishing sessions, or help
  avoid FSM problems with sessions to certain peers. Not enabled by
  default though.

16 years ago[administrivia] Ignore rebase files and .msg
Paul Jakma [Sun, 19 Feb 2006 17:17:14 +0000 (17:17 +0000)]
[administrivia] Ignore rebase files and .msg
(cherry picked from c5b85efd767b82fcb46b20ac6202c828d91aacb3 commit)

16 years ago[git administrivia] remove auto-built quagga.info, add to gitignore.
Paul Jakma [Sun, 19 Feb 2006 17:45:56 +0000 (17:45 +0000)]
[git administrivia] remove auto-built quagga.info, add to gitignore.

16 years ago[administrivia] Add .gitignore files, based on .cvsignores.
Paul Jakma [Sun, 19 Feb 2006 17:30:10 +0000 (17:30 +0000)]
[administrivia] Add .gitignore files, based on .cvsignores.

16 years ago[bgpd] Fix triggerable crash when compiled with --disable-bgp-announce
Paul Jakma [Tue, 22 Jul 2008 21:11:48 +0000 (21:11 +0000)]
[bgpd] Fix triggerable crash when compiled with --disable-bgp-announce

2008-07-22 Paul Jakma <paul.jakma@sun.com>

* HACKING: Document preference for compiler conditional code, over
  cpp conditional.
* configure.ac: DISABLE_BGP_ANNOUNCE always should be defined.
* bgp_{packet,route,advertise}.c: change to compiler testing of
  DISABLE_BGP_ANNOUNCE, rather than cpp.

2008-07-22 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp>

* bgp_packet.c: (bgp_update_packet_eor) Fix crash triggerable
  if a bgpd was compiled with --disable-bgp-announce and if GR is
  advertised by peer.

16 years ago[bgpd] fix a couple of trivial compiler warnings
Paul Jakma [Tue, 22 Jul 2008 19:56:56 +0000 (19:56 +0000)]
[bgpd] fix a couple of trivial compiler warnings

2008-07-22 Paul Jakma <paul.jakma@sun.com>

* bgp_community.c: (community_str2com) assigns defaults to local
  vars
* bgp_attr.c: (bgp_attr_parse) match format specifier to arg
* bgp_table.{c,h}: (bgp_table_top) can take a * to a const, quelling
  warning in bgp_route.c

16 years ago[bgpd] TCP-MD5: password vty configuration and initial Linux support
Paul Jakma [Mon, 21 Jul 2008 21:02:49 +0000 (21:02 +0000)]
[bgpd] TCP-MD5: password vty configuration and initial Linux support

2008-07-21 Paul Jakma <paul.jakma@sun.com>

* bgp_packet.c: (bgp_open_receive) fix warning in a zlog call
* bgp_vty.c: (bgp_vty_return) add return code
* bgpd.c: (bgp_master_init) setup the socket list.
* bgp_network.c: Remove the dual IPv4/6 socket thing for now, which
  was implemented by Michael, until such time as its clear its
  required for Linux (see sockopt comments). IPv6 support, including
  IPv4 sessions on AF_INET6 sockets, therefore is broken, and the
  '-l 0.0.0.0' arguments would need to be given to bgpd to make
  things work here.

2008-07-21 Michael H. Warfield <mhw@wittsend.com>
           YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>
   Tomohiko Kusuda <kusuda@inetcore.com>
           Leigh Brown <leigh@solinno.co.uk>

* bgp_network.c: (bgp_md5_set_one) shim between libzebra tcp-md5
  sockopt and bgpd.
  (bgp_md5_set_socket) Helper for bgp_connect
  (bgp_md5_set) setup TCP-MD5SIG for the given peer.
  (bgp_connect) call out to bgp_md5_set_socket for the outgoing
  connect socket.
  (bgp_socket) save references to the listen sockets, needed if
  TCP-MD5SIG is applied later or changed.
* bgp_vty.c: (*neighbor_password_cmd) New 'neighbor ... password'
  commands.
* bgpd.c: (peer_{new,delete) manage TCP-MD5 password
  (peer_group2peer_config_copy) inherit TCP-MD5 password
  (peer_password_{un,}set) orchestrate the whole add/remove of TCP-MD5
  passwords: applying checks, stopping peers, and trying to return
  errors to UI, etc.
  (bgp_config_write_peer) save password.
  Fix missing newline in writeout of neighbor ... port.

2008-07-21 Paul Jakma <paul.jakma@sun.com>

* sockunion.c: ifdef out various places that converted
  v4mapped sockets to pure v4. Doesn't seem necessary at all,
  presumably a workaround for now historical inet_ntop bugs (?)

2008-07-21 Michael H. Warfield <mhw@wittsend.com>
           YOSHIFUJI Hideaki <yoshfuji@linux-ipv6.org>

* sockopt.{c,h}: (sockopt_tcp_signature) Add TCP-MD5SIG support.

16 years ago[tools/multiple-bgpd.sh] make it easier to use IPv6 peer addresses
Paul Jakma [Mon, 21 Jul 2008 18:43:04 +0000 (18:43 +0000)]
[tools/multiple-bgpd.sh] make it easier to use IPv6 peer addresses

16 years ago[solaris] Sync SMF bits with OpenSolaris SFW
Paul Jakma [Thu, 3 Jul 2008 20:41:08 +0000 (20:41 +0000)]
[solaris] Sync SMF bits with OpenSolaris SFW

2008-07-03 Paul Jakma <paul.jakma@sun.com>

* quagga.{xml,init}.in: Sync with OpenSolaris SFW. This changes the
  SMF schema used, from the SMF schema supplied initially with
  Quagga, to the version which was approved by the Sun PSARC for
  inclusion into Solaris. This change is incompatible. Settings,
  such as vty_port, etc. will not transfer over. The Sun schema is
  however supported by Sun, and supports running Quagga in a zone
  with IP instances, and configuration via the routeadm utility.

16 years ago[vtysh] small fix to previous CMD_AS_RANGE patch, and add missing command
Paul Jakma [Thu, 3 Jul 2008 19:34:48 +0000 (19:34 +0000)]
[vtysh] small fix to previous CMD_AS_RANGE patch, and add missing command

2008-07-03 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp>

* extract.pl.in: Fix as-range to match CPP output.
* vtysh.c: Add missing router_bgp_view_cmd alias.

16 years ago[vty] CMD_AS_RANGE accidently quoted and so not expanded in vty
Paul Jakma [Wed, 2 Jul 2008 13:40:33 +0000 (13:40 +0000)]
[vty] CMD_AS_RANGE accidently quoted and so not expanded in vty

2008-07-02 MIYAJIMA Mitsuharu <miyajima.mitsuharu@anchor.jp>

* *.c: CMD_AS_RANGE was being used inside command strings, and thus
  not being expanded, fix by dequoting.

16 years ago[bgpd] Fix double-free crash in bgp_table_finish, seen with rs-client
Paul Jakma [Wed, 2 Jul 2008 02:12:07 +0000 (02:12 +0000)]
[bgpd] Fix double-free crash in bgp_table_finish, seen with rs-client

2008-07-02 Stephen Hemminger <stephen.hemminger@vyatta.com>

* bgp_table.{c,h}: (bgp_table_finish) Take a double pointer and
  scrub pointer in caller, so fixing double-free crashes seen
  with route-server-client configuration.
* *.c: Adjust all callers of bgp_table_finish

2008-07-02 Paul Jakma <paul.jakma@sun.com>

* bgp_table.{c,h}: (bgp_node_delete, bgp_table_free) shouldn't be
  exported.

16 years ago[zebra] Make BSD link-state deal more gracefully with GIFMEDIA ioctl error
Paul Jakma [Tue, 1 Jul 2008 18:24:58 +0000 (18:24 +0000)]
[zebra] Make BSD link-state deal more gracefully with GIFMEDIA ioctl error

2008-07-01 Paul Jakma <paul.jakma@sun.com>

* ioctl.c: (if_get_flags) Deal more gracefully with failure
  of the BSD link-state SIOCGIFMEDIA ioctl, as some interfaces
  apparently don't implement it (e.g. tun).
  Also, make BSD link-state checking be conditional on the
  'link-detect' interface configuration flag, as it should be.
  Fixes bug #465.

16 years ago[tools/multiple-bgpd] setup IPv6 advertisments
Paul Jakma [Thu, 12 Jun 2008 18:53:09 +0000 (18:53 +0000)]
[tools/multiple-bgpd] setup IPv6 advertisments

16 years ago[administrivia] commit missing ChangeLog update...
Paul Jakma [Wed, 11 Jun 2008 19:40:57 +0000 (19:40 +0000)]
[administrivia] commit missing ChangeLog update...

16 years ago[release] Bump version to 0.99.10
Paul Jakma [Tue, 10 Jun 2008 21:25:38 +0000 (21:25 +0000)]
[release] Bump version to 0.99.10

2008-06-10 Paul Jakma <paul@jakma.org>

* configure.ac: Bump version to 0.99.10

16 years ago[tests] BGP MP_(UN)REACH_NLRI unit tests (actual file..)
Paul Jakma [Sat, 7 Jun 2008 20:44:30 +0000 (20:44 +0000)]
[tests] BGP MP_(UN)REACH_NLRI unit tests (actual file..)

2008-06-07 Paul Jakma <paul@jakma.org

* bgp_mp_attr_test.c: MP_(UN)REACH_NLRI unit tests

16 years ago[lib] trivial: add const qualifier to stream_put/write
Paul Jakma [Sat, 7 Jun 2008 20:42:07 +0000 (20:42 +0000)]
[lib] trivial: add const qualifier to stream_put/write

2008-06-07 Paul Jakma <paul@jakma.org>

* stream.{c,h}: (stream_{put,write}) add const qualifier to source
  argument. Change u_char to void *.

16 years ago[bgpd] minor changes to bgp_mp_reach_parse
Paul Jakma [Sat, 7 Jun 2008 20:37:10 +0000 (20:37 +0000)]
[bgpd] minor changes to bgp_mp_reach_parse

2008-06-07 Paul Jakma <paul@jakma.org>

* bgp_attr.{c,h}: (bgp_mp_{un,}reach_parse) export, for unit tests.
* bgp_attr.c: (bgp_mp_reach_parse) Add logging. Tighten length test
  to bounds check against the attribute length rather than the
  stream length..

16 years ago[tests] BGP MP_(UN)REACH_NLRI unit tests
Paul Jakma [Sat, 7 Jun 2008 20:32:38 +0000 (20:32 +0000)]
[tests] BGP MP_(UN)REACH_NLRI unit tests

2008-06-07 Paul Jakma <paul@jakma.org

* bgp_mp_attr_test.c: MP_(UN)REACH_NLRI unit tests

16 years ago+ note the meta-queue in NEWS
Denis Ovsienko [Sat, 7 Jun 2008 17:54:38 +0000 (17:54 +0000)]
+ note the meta-queue in NEWS

16 years ago+ initial edition of meta-queue for RIB updates processing (bug #431)
Denis Ovsienko [Mon, 2 Jun 2008 12:03:22 +0000 (12:03 +0000)]
+ initial edition of meta-queue for RIB updates processing (bug #431)

16 years ago[bgpd] bug #419: partial aspath-limit incorrectly causes session reset
Paul Jakma [Sun, 1 Jun 2008 14:29:03 +0000 (14:29 +0000)]
[bgpd] bug #419: partial aspath-limit incorrectly causes session reset

2008-06-01 jfletche@gmail.com

* bgp_attr.c: (bgp_attr_aspathlimit) fix silly bug in flags check
  that was causing BGP to drop sessions if it received a
  aspath-limit with partial set. Fixes bug #419.

16 years ago[tools] multiple-bgpd.sh: make paths more configurable
Paul Jakma [Sun, 1 Jun 2008 14:26:48 +0000 (14:26 +0000)]
[tools] multiple-bgpd.sh: make paths more configurable

16 years ago[ripd] Fix mistaken empty string test
Paul Jakma [Thu, 29 May 2008 19:03:08 +0000 (19:03 +0000)]
[ripd] Fix mistaken empty string test

2008-05-29 Stephen Hemminger <stephen.hemminger@vyatta.com>

* ripd.c: (rip_auth_md5) fix bogus empty string test

16 years ago[daemons] Sanity check port number arguments before use
Paul Jakma [Thu, 29 May 2008 18:29:16 +0000 (18:29 +0000)]
[daemons] Sanity check port number arguments before use

2008-05-29 Martin Nagy <mnagy@redhat.com>

* */*main.c: Sanity check port numbers before using.

16 years ago[zebra/linux] Use BPF to filter out responses, to try avoid netlink overruns
Paul Jakma [Thu, 29 May 2008 18:23:08 +0000 (18:23 +0000)]
[zebra/linux] Use BPF to filter out responses, to try avoid netlink overruns

2008-05-29 Stephen Hemminger <stephen.hemminger@vyatta.com>

* rt_netlink.c: (netlink_install_filter) BPF filter to catch and
  drop responses to zebra's own route messages.
  (kernel_init) add BPF filter on the netlink socket.

17 years ago+ fix the set statement name
Denis Ovsienko [Thu, 10 Apr 2008 11:53:33 +0000 (11:53 +0000)]
+ fix the set statement name

17 years ago+ [bgpd] Added new route-map set statement: "as-path ignore"
Denis Ovsienko [Thu, 10 Apr 2008 11:47:45 +0000 (11:47 +0000)]
+ [bgpd] Added new route-map set statement: "as-path ignore"

17 years ago[bgpd] remove unnecessary 0 entries from struct message's
Paul Jakma [Thu, 13 Mar 2008 03:31:24 +0000 (03:31 +0000)]
[bgpd] remove unnecessary 0 entries from struct message's

2008-03-13 Paul Jakma <paul.jakma@sun.com>

* (various) Remove 0 entries from struct message's, unneeded due to
  recent improvements in mes_lookup/LOOKUP.