doc: fix several warnings in dev docs

Clean up several sphinx warnings in the dev docs:
add bmp to bgp TOC; fix some indenting; escape some asterisks.

Signed-off-by: Mark Stapp <mjs@cisco.com>

Merge pull request #16718 from louis-6wind/fix-asla-length

isisd: fix crash when reading asla

Merge pull request #16778 from aapostoliuk/16628-master

nhrpd: Added a command "no tunnel protection vici profile PROFILE"

Merge pull request #16772 from louis-6wind/fix-isis-affinity

isisd: fix crash at flex-algo affinity setting

Merge pull request #16759 from lsang6WIND/ospf_log

ospfd: logging behavior for area id mismatches

Merge pull request #16748 from opensourcerouting/fix/issue_12502

bgpd: Validate imported routes next-hop that is in a default VRF

Merge pull request #15259 from dmytroshytyi-6WIND/nexthop_resolution

zebra: add LSP entry to nexthop via recursive (part 2)

nhrpd: Added a command "no tunnel protection vici profile PROFILE"

For compatibility with frr-reload, a command
"no tunnel protection [vici profile PROFILE [fallback-profile FALLBACK]]"
was added.

Signed-off-by: aapostoliuk <a.apostoliuk@vyos.io>

Merge pull request #16768 from sri-mohan1/srib-24-frr-a

bgpd: changes for code maintainability

bgpd: changes for code maintainability

these changes are for improving the code maintainability and readability

Signed-off-by: sri-mohan1 <sri.mohan@samsung.com>

Merge pull request #16777 from LabNConsulting/chopps/pytest-config-update

tests: add asyncio default config param to quiet warning

tests: add asyncio default config param to quiet warning

Update the topotest doc to the latest pytest* pkg versions
known to work together

Signed-off-by: Christian Hopps <chopps@labn.net>

isisd: fix flex-algo northbound configuration

ISIS flex-algo cannot be configured in the same northbound transaction.

> # cat config3
> router isis 1
>  flex-algo 129
>   priority 128
>
> # vtysh -f config3
> % Configuration failed.
>
> Error type: validation
> The following commands were dynamically grouped into the same transaction and rejected:
> - router isis 1
> - flex-algo 129
> - priority 128
> [1523430|isisd] done

Do not check data presence in running datastore in validation state.

Fixes: 893882ee20 ("isisd: add isis flex-algo configuration backend")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

isisd: avoid nb_running_get_entry during validation

Avoid calling nb_running_get_entry() during northbound validation.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

isisd: fix flex-algo affinity setting

The following causes a validation error.

> # cat config
> affinity-map green bit-position 0
> router isis 1
>  flex-algo 129
>   affinity exclude-any green
> # vtysh -f config

> Error type: validation
> Error description: affinity map green isn't found
> The following commands were dynamically grouped into the same transaction and rejected:
> - affinity-map green bit-position 0
> - router isis 1
> -  flex-algo 129
> -   affinity exclude-any green

Data does not exist in memory in validation state.

Get data from the candidate northbound config instead.

Fixes: 893882ee20 ("isisd: add isis flex-algo configuration backend")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

isisd: fix crash at flex-algo affinity setting

The following causes a isisd crash.

> # cat config
> affinity-map green bit-position 0
> router isis 1
>  flex-algo 129
>   affinity exclude-any green
> # vtysh -f config

> #0  raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:50
> #1  0x00007f650cd32756 in core_handler (signo=6, siginfo=0x7ffc56f93070, context=0x7ffc56f92f40) at lib/sigevent.c:258
> #2  <signal handler called>
> #3  __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:50
> #4  0x00007f650c91c537 in __GI_abort () at abort.c:79
> #5  0x00007f650cd007c9 in nb_running_get_entry_worker (dnode=0x0, xpath=0x0, abort_if_not_found=true, rec_search=true) at lib/northbound.c:2531
> #6  0x00007f650cd007f9 in nb_running_get_entry (dnode=0x55d9ad406e00, xpath=0x0, abort_if_not_found=true) at lib/northbound.c:2537
> #7  0x000055d9ab302248 in isis_instance_flex_algo_affinity_set (args=0x7ffc56f947a0, type=2) at isisd/isis_nb_config.c:2998
> #8  0x000055d9ab3027c0 in isis_instance_flex_algo_affinity_exclude_any_create (args=0x7ffc56f947a0) at isisd/isis_nb_config.c:3155
> #9  0x00007f650ccfe284 in nb_callback_create (context=0x7ffc56f94d20, nb_node=0x55d9ad28b540, event=NB_EV_VALIDATE, dnode=0x55d9ad406e00, resource=0x0, errmsg=0x7ffc56f94de0 "",
>     errmsg_len=8192) at lib/northbound.c:1487
> #10 0x00007f650ccff067 in nb_callback_configuration (context=0x7ffc56f94d20, event=NB_EV_VALIDATE, change=0x55d9ad406d40, errmsg=0x7ffc56f94de0 "", errmsg_len=8192) at lib/northbound.c:1884
> #11 0x00007f650ccfda31 in nb_candidate_validate_code (context=0x7ffc56f94d20, candidate=0x55d9ad20d710, changes=0x7ffc56f94d38, errmsg=0x7ffc56f94de0 "", errmsg_len=8192)
>     at lib/northbound.c:1246
> #12 0x00007f650ccfdc67 in nb_candidate_commit_prepare (context=..., candidate=0x55d9ad20d710, comment=0x0, transaction=0x7ffc56f94da0, skip_validate=false, ignore_zero_change=false,
>     errmsg=0x7ffc56f94de0 "", errmsg_len=8192) at lib/northbound.c:1317
> #13 0x00007f650ccfdec4 in nb_candidate_commit (context=..., candidate=0x55d9ad20d710, save_transaction=true, comment=0x0, transaction_id=0x0, errmsg=0x7ffc56f94de0 "", errmsg_len=8192)
>     at lib/northbound.c:1381
> #14 0x00007f650cd045ba in nb_cli_classic_commit (vty=0x55d9ad3f7490) at lib/northbound_cli.c:57
> #15 0x00007f650cd04749 in nb_cli_pending_commit_check (vty=0x55d9ad3f7490) at lib/northbound_cli.c:96
> #16 0x00007f650cc94340 in cmd_execute_command_real (vline=0x55d9ad3eea10, vty=0x55d9ad3f7490, cmd=0x0, up_level=0) at lib/command.c:1000
> #17 0x00007f650cc94599 in cmd_execute_command (vline=0x55d9ad3eea10, vty=0x55d9ad3f7490, cmd=0x0, vtysh=0) at lib/command.c:1080
> #18 0x00007f650cc94a0c in cmd_execute (vty=0x55d9ad3f7490, cmd=0x55d9ad401d30 "XFRR_end_configuration", matched=0x0, vtysh=0) at lib/command.c:1228
> #19 0x00007f650cd523a4 in vty_command (vty=0x55d9ad3f7490, buf=0x55d9ad401d30 "XFRR_end_configuration") at lib/vty.c:625
> #20 0x00007f650cd5413d in vty_execute (vty=0x55d9ad3f7490) at lib/vty.c:1388
> #21 0x00007f650cd56353 in vtysh_read (thread=0x7ffc56f99370) at lib/vty.c:2400
> #22 0x00007f650cd4b6fd in event_call (thread=0x7ffc56f99370) at lib/event.c:1996
> #23 0x00007f650ccd1365 in frr_run (master=0x55d9ad103cf0) at lib/libfrr.c:1231
> #24 0x000055d9ab29036e in main (argc=2, argv=0x7ffc56f99598, envp=0x7ffc56f995b0) at isisd/isis_main.c:354

Configuring the same in vtysh configure interactive mode works properly.
When using "vtysh -f", the northbound compatible configuration is
committed together whereas, in interactive mode, it committed line by
line. In the first situation, in validation state nb_running_get_entry()
fails because the area not yet in running.

Do not use nb_running_get_entry() northbound validation state.

Fixes: 893882ee20 ("isisd: add isis flex-algo configuration backend")
Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>

ospfd: logging behavior for area id mismatches

When an ospf interface is not in the backbone area, but it receives a
packet from the backbone, no logs are generated for this mismatch.
However, the opposite scenario does generate logs.
Add a log for this case.

Signed-off-by: Loïc Sang <loic.sang@6wind.com>

Merge pull request #16764 from LabNConsulting/chopps/fix-clang-sa-warning

lib: fix clang SA warnings

Merge pull request #15679 from cscarpitta/test-srv6-sid-manager

tests: Add topotest to validate the sharing of an SRv6 locator among multiple protocols

Merge pull request #16756 from sri-mohan1/srib-24-frr-a

bgpd: changes for code maintainability

lib: fix clang SA warnings

Also, cleanup some unreachable code in `nb_op_sib_next()`.

Signed-off-by: Christian Hopps <chopps@labn.net>

Merge pull request #16762 from LabNConsulting/chopps/diag-diff

improve @retry decorator

tests: log json diff output at debug level while retrying

Signed-off-by: Christian Hopps <chopps@labn.net>

tests: optionally pass `seconds_left` to retrying functions

This allows retrying functions to possibly change their logging level
for diagnostics.

In order to maintain backward compatibility with this longstanding
function we catch the specific exception of it not being handled by the
retrying function and call again w/o the argument.

Signed-off-by: Christian Hopps <chopps@labn.net>

tests: Add SRv6 SID Manager mem leak testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager ping testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager VPN RIB testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager SRv6 loc testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager RIB IPv6 testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager RIB IPv4 testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager ISIS adj testcase

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager check rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager open json

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager check ping

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager json cmp

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager teardown module

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager setup module

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: SRv6 SID Manager build topology

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add SRv6 SID Manager topotest

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vpn rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vrf20 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 vrf10 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt6 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for rt6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt5 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt4 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt3 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt2 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt2

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ISIS adj

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 SRv6 locators

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ipv6 routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 ip routes

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vpn rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vrf20 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify rt1 vrf10 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add ISIS configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for rt1

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for dst

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add sharp configuration for dst

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce6 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce6

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce5 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce5

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce4 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce4

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce3 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add zebra configuration for ce3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add BGP configuration for ce3

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>

tests: Add json to verify ce2 rib

Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>