]>
git.puffer.fish Git - matthieu/frr.git/log
Mitesh Kanjariya [Mon, 23 Oct 2017 09:07:36 +0000 (02:07 -0700)]
zebra: remove l3vni/rmac from gw macip APIs
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sun, 22 Oct 2017 10:46:49 +0000 (03:46 -0700)]
zebra: only write vni config under vrf if the vni is valid
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sun, 22 Oct 2017 08:16:54 +0000 (01:16 -0700)]
zebra: re-install remote next-hop neigh entries upon age out
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Thu, 19 Oct 2017 09:28:42 +0000 (02:28 -0700)]
bgpd: write vrf import/export RT config to frr.conf
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Thu, 19 Oct 2017 01:08:28 +0000 (18:08 -0700)]
bgpd: update all routes when vrf changes on a VNI
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Wed, 18 Oct 2017 08:46:40 +0000 (01:46 -0700)]
bgpd: uninstall all nh/rmac when l3vni is deleted
Upon a l3vni delete (no vni under a vrf) is executed,
we should uninstall all the RMACs and NHs associated with the l3vni.
This is because by the time we get a route delete in zebra
l3vni is already deleted and we dont have refernce to RMACs and NHs
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 12:25:47 +0000 (05:25 -0700)]
zebra: json support for show evpn rmac specific mac command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 12:14:33 +0000 (05:14 -0700)]
zebra: json support for show evpn rmac vni command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 11:59:42 +0000 (04:59 -0700)]
zebra: json support for show evpn rmac command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 11:32:31 +0000 (04:32 -0700)]
zebra: json support for show evpn specific next-hop command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 11:12:51 +0000 (04:12 -0700)]
zebra: json support for show evpn next-hop l3vni <vni>
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 10:48:06 +0000 (03:48 -0700)]
zebra: json support for show evpn next-hop vni all
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 10:14:14 +0000 (03:14 -0700)]
zebra: json support for show evpn l3vni vni command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 09:59:35 +0000 (02:59 -0700)]
zebra: json support for show evpn l3vni
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 09:30:42 +0000 (02:30 -0700)]
zebra: json support for show vrf vni command
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 08:54:05 +0000 (01:54 -0700)]
bgpd: json support for show bgp vrf <> l3vni info
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 08:33:24 +0000 (01:33 -0700)]
bgpd: json support for show bgp l2vpn evpn vrf-import-rt
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 00:41:04 +0000 (17:41 -0700)]
zebra: free host_list while deleting rmac/nh entry
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 17 Oct 2017 00:31:36 +0000 (17:31 -0700)]
bgpd: set type-2 route flag if necessary in bgp_zebra_witgdraw
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 16 Oct 2017 23:51:32 +0000 (16:51 -0700)]
zebra: show commands for specific rmac/nh entries
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
mitesh [Mon, 16 Oct 2017 21:57:42 +0000 (14:57 -0700)]
zebra: proper refcounting for rmac/nh entries
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.comy>
Mitesh Kanjariya [Mon, 16 Oct 2017 04:19:04 +0000 (21:19 -0700)]
bgpd: do not send label to zebra route add for evpn routes
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sun, 15 Oct 2017 04:12:06 +0000 (21:12 -0700)]
bgpd: only install mac_ip routes in vrf
Signed-off-by: Mitesh Kanjariya<mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sat, 14 Oct 2017 09:56:37 +0000 (02:56 -0700)]
bgpd: use bgp_process while processing evpn routes in vrf
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Fri, 13 Oct 2017 22:48:01 +0000 (15:48 -0700)]
bgpd: set evpn rvtep nexthops as active by default
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Fri, 13 Oct 2017 11:10:03 +0000 (04:10 -0700)]
bgpd: import/unimport vrf routes upon l3vni change
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
mitesh [Fri, 13 Oct 2017 08:13:48 +0000 (01:13 -0700)]
bgpd: program nh/rmac entries
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
mitesh [Wed, 11 Oct 2017 08:32:54 +0000 (01:32 -0700)]
bgpd: program mac-ip routes in matching vrfs
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Tue, 10 Oct 2017 01:12:05 +0000 (18:12 -0700)]
bgpd: import rt to vrf mapping
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 11:55:57 +0000 (04:55 -0700)]
bgpd: rmac ext comm
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 09:49:39 +0000 (02:49 -0700)]
zebra: don't get rmac in remote macip delete
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 09:06:34 +0000 (02:06 -0700)]
bgpd: handle export rt change for vrf
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 08:36:32 +0000 (01:36 -0700)]
bgpd: add VRF export RTs to mac-ip routes
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 08:29:04 +0000 (01:29 -0700)]
bgpd: bgpevpn APIs to get l3vni/rmac and import/export RT list
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 03:43:14 +0000 (20:43 -0700)]
bgpd: link l2vnis(bgpevpn) to l3vni(vrf)
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 03:49:16 +0000 (20:49 -0700)]
zebra: don't get rmac in remote macip add
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 01:34:29 +0000 (18:34 -0700)]
bgpd: import/export rt for BGP vrf
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Mon, 9 Oct 2017 00:46:08 +0000 (17:46 -0700)]
bgpd: l3vni/rmac association with bgp vrf
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sun, 8 Oct 2017 03:26:16 +0000 (20:26 -0700)]
bgpd: Bgpevpn tenant vrf association
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Mitesh Kanjariya [Sun, 8 Oct 2017 01:49:27 +0000 (18:49 -0700)]
zebra, lib: zebra changes for symmetric routing support
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Donald Sharp [Thu, 14 Dec 2017 17:24:52 +0000 (12:24 -0500)]
Merge pull request #1554 from opensourcerouting/cover-fix1
bgpd: fix some coverity scan issues
Donald Sharp [Thu, 14 Dec 2017 16:05:29 +0000 (11:05 -0500)]
Merge pull request #1550 from opensourcerouting/missing-lintian-file
debianpkg: Add missing frr-dbg.lintian-overrides to Makefile
Rafael Zalamena [Thu, 14 Dec 2017 16:00:58 +0000 (14:00 -0200)]
bgpd: handle argv_find_and_parse_afi return value
Handle the return value of argv_find_and_parse_afi() to avoid passing
along bad values.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Rafael Zalamena [Thu, 14 Dec 2017 15:57:03 +0000 (13:57 -0200)]
bgpd: use buffer size instead of hardcoded value
This is a possible buffer overflow.
We should always use the buffer size (whenever possible) to tell
functions what the size of the buffer is, instead of a hardcoded value.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Donald Sharp [Thu, 14 Dec 2017 15:23:54 +0000 (10:23 -0500)]
Merge pull request #1546 from pguibert6WIND/issue__1537
Issue 1537
Renato Westphal [Thu, 14 Dec 2017 14:23:37 +0000 (12:23 -0200)]
Merge pull request #1527 from donaldsharp/zserv_thread
Zserv.h modifications
Rafael Zalamena [Thu, 14 Dec 2017 13:21:40 +0000 (11:21 -0200)]
Merge pull request #1521 from donaldsharp/bufsiz
Cleanup Some Code Issues
Donald Sharp [Thu, 14 Dec 2017 12:40:23 +0000 (07:40 -0500)]
Merge pull request #1536 from opensourcerouting/isis-l2conv
Fix ISIS L2 formations
Martin Winter [Thu, 14 Dec 2017 02:58:33 +0000 (18:58 -0800)]
debianpkg: Add missing frr-dbg.lintian-overrides to Makefile
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Rafael Zalamena [Mon, 11 Dec 2017 20:25:06 +0000 (18:25 -0200)]
isisd: fix l2 neighbor formations
Add a timestamp information for level 2 circuits, otherwise if the
circuit is marked as already processed on level 1 we will not process
level 2 areas.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Philippe Guibert [Wed, 13 Dec 2017 15:50:16 +0000 (16:50 +0100)]
zebra: remove useless iotcl linux calls
As netlink is available for all linux systems ( old linux distributions
are not considered), this commit removes the ipv6 ioctl support for
linux.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Philippe Guibert [Mon, 11 Dec 2017 14:21:04 +0000 (15:21 +0100)]
zebra: ipv6 addressing uses netlink socket instead of standard ioctl
It is possible to configure IPv6 addresses from interfaces by using
netlink socket, intead of using standard sockets.
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
Donald Sharp [Thu, 7 Dec 2017 23:35:29 +0000 (18:35 -0500)]
zebra: Make zserv.h the true api for zapi northbound
zserv.c had a grab bag of function declarations that
did not belong in it. Move those to where they better
belong.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Thu, 7 Dec 2017 15:47:30 +0000 (10:47 -0500)]
zebra: Try to move non zapi cli commands from zserv.c
zserv.c has become a bit of a dumping ground for zebra cli.
I'd like to focus the zserv.c code into it's core functionality
which is handling the zapi interface.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 6 Dec 2017 01:21:37 +0000 (20:21 -0500)]
zebra: Move zebrad initialization outside of cli init
The zebrad initialization does not need to be part of cli
initialization and should be done separately.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Wed, 13 Dec 2017 12:36:57 +0000 (07:36 -0500)]
Merge pull request #1478 from bingen/zeromq4
lib: Address ZMQ lib TODOs
Donald Sharp [Tue, 12 Dec 2017 17:41:07 +0000 (12:41 -0500)]
Merge pull request #1540 from opensourcerouting/isis-spfperf1
isisd: save a clock_gettime() call
Donald Sharp [Tue, 12 Dec 2017 16:59:07 +0000 (11:59 -0500)]
Merge pull request #1539 from LabNConsulting/working/master/community-decisions
COMMUNITY.md: add paragraph on use of development list and discussing…
Martin Winter [Tue, 12 Dec 2017 16:51:25 +0000 (08:51 -0800)]
Merge pull request #1514 from donaldsharp/watchfrr
tools, watchfrr: Modify timeout to 90 seconds
Rafael Zalamena [Tue, 12 Dec 2017 13:47:04 +0000 (11:47 -0200)]
isisd: save a clock_gettime() call
Use the thread cached clock to use as start time. It will save a call to
clock_gettime() and also provide a more 'accurate' time measurement from
the start of the procedure.
Lou Berger [Tue, 12 Dec 2017 13:42:54 +0000 (08:42 -0500)]
COMMUNITY.md: add paragraph on use of development list and discussing/documenting decisions
Rafael Zalamena [Wed, 6 Dec 2017 21:23:55 +0000 (19:23 -0200)]
isisd: fix debug message
Show the actual timer instead of doing the arithmetic operation again.
Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
Jafar Al-Gharaibeh [Mon, 11 Dec 2017 17:51:43 +0000 (11:51 -0600)]
Merge pull request #1526 from chiragshah6/ospfv3_dev
ospf6d: Fix multi nexthop route remove
Donald Sharp [Mon, 11 Dec 2017 17:38:26 +0000 (12:38 -0500)]
bgpd: Fixup buffer sizes for prefix_rd2str
The prefix_rd2str uses a buffer size of RD_ADDRSTRLEN.
Modify the code to consistently use this for all of BGP.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Mon, 11 Dec 2017 13:48:59 +0000 (08:48 -0500)]
bgpd: Modify prefix_rd2str to return "Unknown" when unknown
Make prefix_rd2str return an "Unknown" string when something
goes wrong. This will allow for simplification of the
code that uses prefix_rd2str.
Additionally ensure that size is big enough with an assert.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Renato Westphal [Mon, 11 Dec 2017 17:37:26 +0000 (15:37 -0200)]
Merge pull request #1524 from dslicenc/zebra-ra-display-cm18702
zebra: do not display ipv6 ra commands created by bgpd
Donald Sharp [Tue, 5 Dec 2017 15:09:36 +0000 (10:09 -0500)]
bgpd: Cleanup SA error in ignoring return from function
Ignoring the return from argv_find_and_parse_afi
makes the SA system assume that you could pass a AFI_MAX
value to bgp_show_route. Which in turn would cause
an array out of bounds read.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 14:52:16 +0000 (09:52 -0500)]
eigrpd: Fixup some SA issues
1) strlen(buf) on an uninted value is the wrong thing to do
we should be getting sizeof(buf)
2) tlv is not freed in this error case, so let's free it up.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 14:44:11 +0000 (09:44 -0500)]
bgpd: Fix prefix2str using BUFSIZ to PREFIX_STRLEN
PREFIX_STRLEN is the correct length for buffers needed to output
a prefix2str. Additionally cleanup some setting of the last
value to a `\0` this is handled by prefix2str.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Renato Westphal [Mon, 11 Dec 2017 12:55:03 +0000 (10:55 -0200)]
Merge pull request #1531 from chiragshah6/ospf_vrf_dev
ospfd: prevent passive interface cmd crash
Renato Westphal [Mon, 11 Dec 2017 00:38:02 +0000 (22:38 -0200)]
Merge pull request #1528 from donaldsharp/ldp_macro
ldpd: Switch over to new debug style
Chirag Shah [Fri, 8 Dec 2017 17:33:53 +0000 (09:33 -0800)]
ospfd: prevent passive interface cmd crash
Current OSPF VRF configuration are allow pre-provisining even if
VRF is not configured. In such case ospf->vrf_id would VRF_UNKNOWN,
when passive interface configuration done under such ospf instance,
it would lookup all vrf_device and try to create ifp with unknown
vrf_id.
for passive interface config command lookup ifp for vrf_id is within range.
Ticket:CM-19156
Testing Done:
Configure
Cumulus#: router ospf vrf vrf1
Cumulus(config-router)#: passive interface swp16
interface swp16 not found.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Donald Sharp [Thu, 7 Dec 2017 23:59:54 +0000 (18:59 -0500)]
ldpd: Switch over to new debug style
When compiling ldpd on a mac, there exists a #define MSG_SEND
which conflicts with a define in ldp_debug.h.
During discussion about this we decided that it would be
better to remove the macro massaging that was going on and
to just call our own #define for it.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Rafael Zalamena [Thu, 7 Dec 2017 14:37:10 +0000 (12:37 -0200)]
Merge pull request #1519 from donaldsharp/ptm
Ptm
Rafael Zalamena [Thu, 7 Dec 2017 13:43:38 +0000 (11:43 -0200)]
Merge pull request #1520 from donaldsharp/vrf_leaking
Cleanup a bunch of code
Chirag Shah [Fri, 1 Dec 2017 01:45:12 +0000 (17:45 -0800)]
ospf6d: Fix multi nexthop route remove
Fix sorting of route storage to DB.
Fix two list comparison which allows route with
multiple nexthop to updates.
Ticket:CM-19025
Testing Done:
Configured a topology where ospf6 learn
ecmp route via one neighbor and upon removal
of intra-prefix route from origin, DUT removes
ECMP intra-prefix route from RIB.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Don Slice [Wed, 6 Dec 2017 17:00:48 +0000 (09:00 -0800)]
zebra: do not display ipv6 ra commands created by bgpd
If the frr.conf file contains bgp unnumbered peering but the associated
interfaces do not have the commands "no ipv6 nd suppress-ra" and
"ipv6 nd ra-interval 10" configured, when frr-reload.py is issued the
interface commands are removed from the running config, causing peers to
got down and stay down after a link flap. This situation can occur if
the frr.conf file is created manually or via automation (like ansible)
but a subsequent "wr mem" has not been performed.
This fix changes the behavior so that the interface ipv6 nd ra commands
created by bgp are not displayed. Therefore, when the above condition
occurs, there is no difference between the running and stored configs
and peers work fine.
Ticket: CM-18702
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-7004
Testing-done: Manual testing successful. L3-smoke has no new failures
Renato Westphal [Tue, 5 Dec 2017 16:47:53 +0000 (14:47 -0200)]
Merge pull request #1502 from chiragshah6/ospf_vrf_dev
ospfd: Display all vrf aware ospf interface config
Donald Sharp [Tue, 5 Dec 2017 12:03:15 +0000 (07:03 -0500)]
Merge pull request #1494 from opensourcerouting/u1710-master
Fixes to allow Package build on Ubuntu 17.10
Martin Winter [Thu, 30 Nov 2017 03:23:20 +0000 (19:23 -0800)]
debianpkg: Update Pkg build instructions with Ubuntu 17.10 and fix errors
- plus add pointer for creating new backport
- plus add example for customizing package with WANT_* options
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Wed, 29 Nov 2017 09:17:28 +0000 (01:17 -0800)]
debianpkg: Add Debian backport for Ubuntu 17.10
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Wed, 29 Nov 2017 09:05:46 +0000 (01:05 -0800)]
debianpkg: Fix lintian warning "command-with-path-in-maintainer-script"
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Tue, 5 Dec 2017 08:26:41 +0000 (00:26 -0800)]
lib: Fix gcc 7 warning 'error: ‘fld’ may be used uninitialized in this function'
Warning breaks Debian Package build with gcc 7 which uses -Werror=maybe-uninitialized
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Martin Winter [Wed, 29 Nov 2017 09:29:04 +0000 (01:29 -0800)]
bgpd: bgp_attr.c GCC 7.0 with --werror needs explicit fall-thru comment
Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
Donald Sharp [Tue, 5 Dec 2017 02:26:57 +0000 (21:26 -0500)]
bgpd: Cleanup unneeded NULL checks.
All the NULL checks come after previous dereferences.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 02:26:05 +0000 (21:26 -0500)]
watchfrr: Fail gracefully if fopen fails
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 01:51:34 +0000 (20:51 -0500)]
bgpd, zebra: Use sscanf return value
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 01:43:46 +0000 (20:43 -0500)]
bgpd: Tell the compiler we don't care about the return code for peer_sort
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 01:33:44 +0000 (20:33 -0500)]
bgpd: Reorder assignment and assertion.
If we ever turn off assertion for production builds
this code as written will cause a crash in that
the assignment will not happen.
Modify the code such that this erroneous assumption
cannot happen.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 00:29:42 +0000 (19:29 -0500)]
babeld: if_eui64 never uses ifname
Remove this variable.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Chirag Shah [Mon, 4 Dec 2017 22:08:23 +0000 (14:08 -0800)]
ospfd: fix crash no router ospf/show running
no router ospf removes default ospf instance,
if there are other non-default vrf instance present
with interface level configuration. Lookup ospf instance
for ifp->vrf_id, if ospf instnace present use that
to access 'instance id'.
Ticket: CM-19078
Testing Done:
run no router ospf and show running config along with other
non-default vrf aware ospf configurations.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Donald Sharp [Tue, 5 Dec 2017 00:03:51 +0000 (19:03 -0500)]
zebra: Cleanup leaked context information on failure
When we get a STREAM_GET failure of some sort we
need to handle the failure case here and safely
free up stored memory/context and return gracefully.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Donald Sharp [Mon, 4 Dec 2017 23:59:47 +0000 (18:59 -0500)]
lib: Allow memory to be cleaned up for error cases in ptm
ptm_lib.c had no way to cleanup after itself when an
error was detected. This adds a function to cleanup
context in such a case.
A followup commit will use this new functionality.
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Chirag Shah [Mon, 27 Nov 2017 21:59:19 +0000 (13:59 -0800)]
ospfd: Display all vrf aware interface config
OSPF interface specific configuration can be done independent
of router ospf [vrf x] global config.
In cases where ospf interface non default vrf configuration
is done prior to 'router ospf vrf x', show running-config
would not display such configuration.
To display configuration now walk all vrfs and interface list
and only display where OSPF configure params are set.
Ticket:CM-18952
Testing Done:
Tried ospf interface specific configuration with VRF,
where router ospf vrf x is not present.
Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Donald Sharp [Mon, 4 Dec 2017 22:45:05 +0000 (17:45 -0500)]
Merge pull request #1518 from opensourcerouting/clippy-issues
*: make clippy usage more consistent
Renato Westphal [Mon, 4 Dec 2017 21:32:20 +0000 (19:32 -0200)]
*: make clippy usage more consistent
Fixes #1511.
Signed-off-by: Renato Westphal <renato@opensourcerouting.org>
Renato Westphal [Mon, 4 Dec 2017 20:25:16 +0000 (18:25 -0200)]
Merge pull request #1496 from donaldsharp/install_failure
Additional Southbound API changes
Renato Westphal [Mon, 4 Dec 2017 19:34:19 +0000 (17:34 -0200)]
Merge pull request #1507 from donaldsharp/bgp_af_open
bgpd: Allow Address-Family activation to work in certain states
Brian Rak [Wed, 15 Nov 2017 19:51:37 +0000 (14:51 -0500)]
tools, watchfrr: Modify timeout to 90 seconds
The default timeout of 10 seconds is too quick of a timeout
given some long running cli commands. Modify watchfrr
to have a 90s timeout value instead.
Signed-off-by: Brian Rak <brianrak@gameservers.com>
Donald Sharp [Mon, 4 Dec 2017 14:06:09 +0000 (09:06 -0500)]
Merge pull request #1500 from opensourcerouting/ldpd-fixes
ldpd: small improvements