zebra: "debug zebra packet" config display

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Merge pull request #828 from tigranmartirosyan/master

#752 ARP is not updating if mac address changed on remote side

Add 1 more identation to correspond to kernel style multi-line comment

Merge pull request #833 from dslicenc/cm16779-bgp-startup-ll

bgpd: fix peer startup for labeled-unicast if linklocal address not f…

Merge pull request #827 from devicenull/patch-1

Add note about bridge limitations

Merge pull request #805 from Orange-OpenSource/master

Add OSPF API and FRR Hacking documents

bgpd: fix peer startup for labeled-unicast if linklocal address not found

Problem found in testing where ipv6 labeled-unicast prefixes were not received
on the peers if a "service networking restart" was issued.  Same problem would
happen with an ifdown/ifup on the link to the peer.  Found the problem to be
that peers would establish for labeled-unicast even if a link-local address was
not yet available on the interface toward the peer, causing updates to be sent
without a nexthop value. These were then rejected by the peer. Fix is to delay
peer establishment until after the link-local addresses are available.

Ticket: CM-16779
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed By: Donald Sharp <sharpd@cumulusnetworks.com>
Testing Done: Manual testing successful.  Bgp-smoke completed with no new failures

replace space to tabs, add kernel styles multiline, remove trailing whitespaces.

*: reindent pt. 2

w/ clang 5

* reflow comments
* struct members go 1 per line
* binpack algo was adjusted

Add note about bridge limitations

Add note that Zebra will never be able to detect the master interface for any interface due to IFLA_INFO_SLAVE_KIND not being defined

Merge pull request #826 from qlyoung/rm-vtyoutln

eigrpd: remove last vty_outln

eigrpd: remove last vty_outln

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

merge with upstream

*: reindent

indent.py `git ls-files | pcregrep '\.[ch]$' | pcregrep -v '^(ldpd|babeld|nhrpd)/'`

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: add indent control files

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #818 from donaldsharp/eigrp_afi

Eigrp afi

Merge pull request #820 from opensourcerouting/gcc7

fix new warnings emitted by GCC 7

Merge pull request #794 from opensourcerouting/table-hash-ospf6-lsdb-refactor

use hash in lib/table, also refactor ospf6 lsdb code

lib: parser: remove incorrect assert

A {foo|bar|baz} graph node will have more than 1/2 incoming links even
if no other references are left to it (which is what the assert was
previously trying to ensure.)

I don't see a good way to "fix" the assert so I'm just removing it.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #806 from dwalton76/bgpd-set-ipv4-vpn-nexthop

bgpd: "set ipv4 vpn next-hop 1.1.1.1" is saved/displayed as "set ip vpn next-hop 1.1.1.1"

tests/ospf6d/test_lsdb: remove vty_outln

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge remote-tracking branch 'frr/master' into table-hash-ospf6-lsdb-refactor

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

nhrpd: enable -Werror

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: fix GCC 7 warnings/issues

The label initializer & nhrpd variable are just to shut up GCC 7,
the other two are actual bugs.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: fix GCC 7 switch/case fallthrough warnings

Need a comment on these.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #803 from opensourcerouting/redhat-doc-fixes-master

Redhat doc fixes for master branch

Merge pull request #809 from donaldsharp/evpn_plus_struct_attr

Evpn plus struct attr

bgpd, zebra: Cleanup warnings from new code

1) Clean up VTY_NEWLINE -> \n
2) Remove usages of VTY_GET_INTEGER

Signed-off-by: Donald Sharp

Merge remote-tracking branch 'origin/master' into evpn_plus_struct_attr

Merge remote-tracking branch 'origin/master' into evpn_plus_struct_attr

bgpd: Disable new EVPN CLI

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #813 from opensourcerouting/newline-redux

newline redux

Merge pull request #762 from bingen/mutiple_nh_recursive_levels

Allow for more than 1 NH recursion level

Merge pull request #804 from opensourcerouting/fixes/tests/prng

tests: update prng to return better pseudo random numbers

lib, vtysh: remove now-useless newline arg

It's always \n now, hooray.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge remote-tracking branch 'frr/master' into newline-redux

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #799 from dwalton76/bgpd-show-labeled-unicast

bgpd: show bgp ipv4 label-unicast does not provide any output

Merge pull request #808 from qlyoung/vtysh-termcols

lib, vtysh: pretty-print variable autocompletions

*: remove vty_outln again

(PRs merged to master added another few vty_outln() calls)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge remote-tracking branch 'frr/master' into newline-redux

Lots of conflicts from CMD_WARNING_CONFIG_FAILED...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #800 from qlyoung/fix-old-vpn-commands

bgpd: fix old-style vpn commands

Merge pull request #815 from dwalton76/CMD_WARNING_take2

vtysh: return non-zero for configuration failures

Merge pull request #817 from donaldsharp/babel_redist

babeld: Allow babel to redistribute v6 routes

Merge pull request #814 from qlyoung/vtysh-password-commands

vtysh: fixup password commands

*: remove VTYNL, part 6 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: remove VTYNL, part 5 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: remove VTYNL, part 4 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: remove VTYNL, part 3 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: remove VTYNL, part 2 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: remove VTYNL, part 1 of 6

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

ospf6d: VNL -> VTYNL

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: ditch vty_outln(), part 2 of 2

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

eigrpd: Fix up some redistribution issues

Get EIGRP to start attempting to redistribute routes
as well as to display the fact it thinks it is redistributed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Let eigrp setup it's router-id in some situations

If the router-id is passed up to eigrp before we have
started the instance, allow it to set it up properly
as we start the instance.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fixed wrong type used

Recent additions to prefix_copy to check afi type exposed
an issue with eigrp setting the wrong afi type for a `struct prefix`.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

babeld: Allow babel to redistribute v6 routes

Turn on the ability in babel to receive v6 routes when requested.

robot# show babel route
192.168.201.0/24 metric 0 (exported)
2606:a000:111d:803e::/64 metric 0 (exported)
robot# conf t
robot(config)# int enp3s0
robot(config-if)# ipv6 addr 2404:4000:991d:804c:c32:ee94:742c:4d5/73
robot(config-if)# end
robot# show babel route
192.168.201.0/24 metric 0 (exported)
2606:a000:111d:803e::/64 metric 0 (exported)
2404:4000:991d:804c:c00::/73 metric 0 (exported)
robot#

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

vtysh: return non-zero for configuration failures

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
This allows frr-reload.py (or anything else that scripts via vtysh)
to know if the vtysh command worked or hit an error.

vtysh: fixup password commands

`password` and `enable password` commands got a bit broken in an earlier
commit, fix 'em up.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: ditch vty_outln(), part 1 of 2

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: move \n vs. \r\n handling into vty code

Instead of having an ?: expression embedded in every single caller of
vty_out, just expand \n to \r\n in the vty code if neccessary.

(Deprecation warnings will be enabled in the next commits which will do
the search-and-replace over the codebase.)

[This reverts commit 4d5f445 "lib: add vty_outln()"]

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: vty: warn when using compatibility macros

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: COMMUNITY.md: compatibility foo & deprecation

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd: show bgp ipv4 label-unicast does not provide any output

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib, vtysh: pretty-print variable autocompletions

Pretty-prints variable autocompletions by breaking them up into multiple
lines, indenting them consistently and respecting the column width of
the terminal.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Remove FRR-hacking.md documentation

Content is too old and too many changes are needed to achieved an
up to date documentation

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

Merge pull request #807 from Jafaral/qua2frr

Find/Replace Quagga/FRR

zebra: Fix compilation warning

Signed-off-by: ßingen <bingen@voltanet.io>

lib, test: Add test case for ALL_NEXTHOPS_RO

Without it, tests were passing before commit 9fb47c0, so a case was
missing (the one which that commit fixes).

Signed-off-by: ßingen <bingen@voltanet.io>

Merge pull request #798 from dwalton76/CMD_RANGE_STR

bgpd: --enable-multipath=256 setting is ignored

Merge pull request #796 from qlyoung/fix-hash-stats

lib: use 32-bit atomics, s/pow/mul

bgpd: Refactor 'struct attr_extra' into 'struct attr'

Most of the attributes in 'struct attr_extra' allow for
the more interesting cases of using bgp.  The extra
overhead of managing it will induce errors as we add
more attributes and the extra memory overhead is
negligible on anything but full bgp feeds.

Additionally this greatly simplifies the code for
the handling of data.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd: Fix missing label set

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Fix some defines for older platforms

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: On cleanup make sure pointers exist

Test cases create fake bgp structure that is passed to
cleanup.  The new evpn code assumed ( and probably rightly so)
that if the bgp structure was created it actually initialized
all useful data structures.  Just make the evpn cleanup
functions be smart about attempting to free memory never
allocated.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Ensure EVPN next hops are not overriden

Updates: bgpd: Fix next hop setting for EVPN
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: Handle change to router id for EVPN

When the BGP router-id changes, EVPN routes need to be processed due
to potential change to their RD.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: Additional configuration for EVPN

Implement configuration options for EVPN. The configuration options include
VNI configuration with RD and Import and Export Route Targets. Also, display
the EVPN configuration.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: Display (show) commands for EVPN

Implement various operational/display commands for EVPN:
- show bgp evpn summary
- show bgp evpn vni [<vni>]
- show bgp evpn route [type <macip|multicast>]
- show bgp evpn route [rd <rd> [type <macip|multicast>]]
- show bgp evpn route [rd <rd> [mac <mac> [ip <ip>]]]
- show bgp evpn route vni <vni> [type <macip|multicast> | vtep <ip>]
- show bgp evpn route vni <vni> [mac <mac> [ip <ip>]]]
- show bgp evpn route vni <vni> [multicast <ip>]
- show bgp evpn route vni all [vtep <ip>]
- show bgp evpn import-rt

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>

bgpd: Debug logging updates for EVPN

Ensure VNI and EVPN nexthops are logged in debug logs.

Updates: "bgpd: labeled unicast processing"
Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: MAC Mobility extended community string conversion

Updates: d5b9da8a79cbf2acf287bda2600e86a5a3243c64
Updates: 749513cc9d7bf571b3049931057d544b4111c39d

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd, zebra: Support for sticky MACs

Implement support for sticky (static) MACs. This includes the following:

- Recognize MAC is static (using NUD_NOARP flag) and inform BGP
- Construct MAC mobility extended community for sticky MACs as per
RFC 7432 section 15.2
- Inform to zebra that remote MAC is sticky, where appropriate
- Install sticky MACs into the kernel with the right flag
- Appropriate handling in route selection

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: EVPN route handling

Core EVPN route handling functionality. This includes support for the
following:
- interface with zebra to learn about local VNIs and MACIPs as well as
to install remote VTEPs (per VNI) and remote MACIPs
- create/update/delete EVPN type-2 and type-3 routes
- attribute creation, route selection and install
- route handling per VNI and for the global routing table
- parsing of received EVPN routes and handling by route type
- encoding attributes for EVPN routes and EVPN prefix creation (for
Updates)

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>

doc: update a few places to say FRR

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

zebra: rename to frrconfdir

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

tools: update to use FRR name

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

bgpd: "set ipv4 vpn next-hop 1.1.1.1" is saved/displayed as "set ip vpn
next-hop 1.1.1.1"

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Add OSPF API and FRR Hacking documents

 With the help of the WayBackMachine, add old documentation
about the OSPF API and basic Zebra hacking

Signed-off-by: Olivier Dugeon <olivier.dugeon@orange.com>

gitignore: update references to FRR

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

bgpd: Additional check on presence of tag/label

In the case of EVPN, not all EVPN routes will necessarily have a tag/label.
Do an additional check on presence of tag, where needed.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

tests: update prng to return better pseudo random numbers

Signed-off-by: Christian Franke <chris@opensourcerouting.org>

lib: fix error message to reference FRR

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

lib: Define handlers for VNI and MACIP

Define client handlers for processing add or delete of local VNIs
and local MACIPs.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: Install or remove only relevant routes from zebra

Ensure that the AFI/SAFI is relevant to the FIB before attempting to install
or remove the route from zebra.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

lib: Change comment to reference watchfrr

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

bgpd: Implement EVPN enable/disable

Implement the command 'advertise-all-vni' under the EVPN address-family
in order to allow the local system to learn about local VNIs (and MACs
and Neighbors corresponding to those VNIs) and exchange with other EVPN
speakers.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Dinesh Dutt <ddutt@cumulusnetworks.com>

bgpd: EVPN initialization and cleanup

Define the EVPN (EVI) hash table and related structures and initialize
and cleanup.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: EVPN definitions

Define the EVPN (EVI) hash table and objects for mapping route targets to EVIs.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Signed-off-by: Mitesh Kanjariya <mitesh@cumulusnetworks.com>
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: Fix next hop setting for EVPN

The next hop for EVPN routes must be an IPv4 or IPv6 address as per
RFC 7432. Ensure this is correctly handled. Also, ensure there
are correct checks for AFI_L2VPN and nexthop AFI is not AFI_L2VPN.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: Fix check for martian next hops

Ensure that the check for martian next hop is correct, including for MP
nexthops, if IPv4.

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Function to encode Encapsulation type extended community

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>

bgpd: Display extended communities in debug log

Signed-off-by: Vivek Venkatraman <vivek@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>