lib: mt-safe cancel, round deux

* Update pollfds copy as well as the original
* Keep array count for copy in thread_master
* Remove last remnants of POLLHUP in .events field
* Remove unused snmpcount (lolwut)
* Improve docs
* Add missing do_thread_cancel() call in thread_cancel_event()
* Change thread_fetch() to always enter poll() to avoid starving i/o
* Remember to free up cancel_req when destroying thread_master
* Fix dereference of null pointer
* Fix dead store to timeval
* Fix missing condition for condition variable :-)

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add mt-safe thread_cancel

This patch implements an MT-safe version of thread_cancel() in
thread_cancel_async(). Behavior as follows:

* Cancellation requests are queued into a list

* Cancellation requests made from the same pthread as the thread_master
  owner are serviced immediately (thread_cancel())

* Cancellation requests made from a separate pthread are queued and the
  call blocks on a condition variable until the owning pthread services
  the request, at which point the condition variable is signaled and
  execution continues (thread_cancel_async())

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #718 from qlyoung/fix-vtysh-shit

lib: allow 'do' commands in ENABLE_NODE

Merge pull request #726 from chiragshah6/pim_dev

pimd: move variable declartion outside of switch

Merge pull request #620 from qlyoung/termtable

lib: add table generator

lib: allow 'do' commands in ENABLE_NODE

'do' is syntax sugar that allows the user to execute a command under
ENABLE_NODE when in another CLI node. If the user is already in
ENABLE_NODE, use of 'do' was previously disallowed. This patch allows it
because it makes it easier for us to hack around certain instances of
the node synchronization problem with vtysh.

Also included is a fix for one of these problems.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: termtable MTYPE_TMP -> MTYPE_TTABLE

And some style nits.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add table generator

Allows for easy preparation of tabular output.

Supports:
 -- Padding
 -- Alignment
 -- Styling

pimd: move variable declartion outside of switch

To Address ICC (intel CC) warning, moving variables
declaration out of switch statement.

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>

Merge pull request #711 ("Coverity munging")

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

ospfd: fix typo in error message

... and print the invalid input value

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #705 from dwalton76/bgpd-show-neighbor-community

bgpd: "no neighbor x.x.x.x send-community" not displayed correctly

lib: fix protocol name array size

Oops.  Fixes #715.

Reported-by: Daniel Walton <dwalton@cumulusnetworks.com>
Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #716 from dwalton76/show-route-map

lib: "show route-map" is missing from the parser

lib: "show route-map" is missing from the parser

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: Remove unused testzebra and ancillary files

The testzebra command was unused as well as unmaintained.
The NS and VRF changes never made into testzebra so when
you actually ran testzebra it would just crash due to
uninitialized assumptions.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix integer overflow possibility

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Cleanup ifp->info setup

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospfclient: Free up leaked resources in error path

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

*: Clean up call into inet_aton

In the few places where we were not checking the return code
for inet_aton, do so.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge branch 'stable/3.0'

Dropped:
redhat/README.rpm_build.md
redhat/daemons
redhat/frr.init
redhat/frr.logrotate
redhat/frr.spec.in

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #681 (ASAN warnings)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #687 (nexthop refactoring)

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #624 "Babel"

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

babeld/eigrpd: flip VTY ports & fix rpm

babeld was 2609 previously, and this was still marked in SERVICES.
Let's flip it back before we have a release out with it.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #703 from donaldsharp/nl_pid

zebra: When calling netlink, set the nl_pid as appropriate

Merge pull request #700 "Coverity high"

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #678

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

babeld: install directly connected IPv4 as such

babeld would install "1.2.3.4 on eth0" as "1.2.3.4 via 1.2.3.4 on eth0".
Remove the superfluous nexthop and send to zebra as directly-connected
route.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge remote-tracking branch 'frr/master' into pull-624

bgpd: "no neighbor x.x.x.x send-community" not displayed correctly

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
We would only diplay one "no neighbor 2.2.2.2 send-community XYZ" but
there might be multiple that need to be displayed.

zebra: When calling netlink, set the nl_pid as appropriate

This will allow us to further know that we originated the message.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix memory leak

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix uninitialized memory access with src_p

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Correctly size the dump data

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Use correct memory operation

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix leak of ep

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Cleanup leaked dest_addr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix use after free

Signed-off-by: Donald Sharp <sharpd@Cumulusnetworks.com>

zebra: Fix possible buffer overrun

Use the correct size of the string.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Free allocated stream in error code

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: fix memleak with 'show ip bgp vrf ...'

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #679 from dslicenc/cm16513

bgpd: add "set label-index" route-map option

Merge pull request #694 from qlyoung/event-loop

*: remove THREAD_BACKGROUND

isisd: fix heap uaf, round 2

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #692 from donaldsharp/meta_queue_fix

zebra: Fix the metaq to be aware of all routing protocols we could see

Merge pull request #693 from donaldsharp/more_newlines_missing

bgpd: Fix missing newline

Merge pull request #697 from donaldsharp/rt_proto_fixes

tools, zebra: Fix netlink notification of who owns the routes

Merge pull request #696 from donaldsharp/disable_rtadv

zebra: Fix --disable-rtadv to actually compile

zebra: In which RTPROT_BABEL is hard

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: For older distributions RTPROT_BABEL might not be defined

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

tools, zebra: Allow zebra to insert babel routes as babel

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

tools, zebra: Fix netlink notification of who owns the routes

For NHRP, EIGRP and LDP( This is for consistency as opposed to correctness )
assign some new values to routes to be installed into the kernel
so we can know who owns them later.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix --disable-rtadv to actually compile

Signed-off-by: Alex Couloumbis <alex@ozo.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

*: remove THREAD_BACKGROUND

it's just an alias for a millisecond timer used in exactly nine places
and serves only to complicate

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: Fix missing newline

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Add babel routes to the proper meta-Q for processing

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add some breadcrumbs for new route types

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fix the metaq to be aware of all routing protocols we could see

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #678 from chiragshah6/pim_dev

pimd: fix pim bfd crash and bfd down check specific neigh addr

Merge pull request #688 from opensourcerouting/openbsd-mpls-fixes

Small fixes for OpenBSD

doc: update build instructions for openbsd

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

zebra: fix uninstallation of mpls lsps in openbsd

While here, fix a warning in kernel_lsp_cmd().

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

ldpd: remove pledge calls

In OpenBSD pledge is a mitigation mechanism used to restrict the syscalls
a program can use, enforcing its correct behavior.

In this port of OpenBSD's ldpd(8), it's hard to run under the same
tight pledge promises because of libfrr and additional components we
introduced, like a zclient in lde. Since ldpd is already privsep'ed,
removing the pledge calls shouldn't be a big compromise security-wise.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

Merge pull request #686 from opensourcerouting/redhat-3.0-nhrp

Redhat: Add remaining NHRP modifications to match 2.0 and master branch

zebra: Clean up indentation level in nexthop_active

Clean up the while loop indentation level to be a bit more
readable.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Refactor nexthop_active to remove duplicate code

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Redhat: Add remaining NHRP modifications to match 2.0 and master branch

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

isisd: fix heap uaf

Fix #671

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: fix misc zebra leaks

Fix #669

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #684 from donaldsharp/redhat_3.0

Redhat 3.0

redhat: Fix changelog to be in correct format and order

redhat: Fix missing packages in requirements section of README

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Disallow reload function for unsupported systems

Before the change, a reload triggered a restart if the python reload script wasn't installed or for non-integrated configs
With this change, the reload is rejected with an error in this case (and suggests the installation of the python script package)

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: fix previous merge. initsystem detection should now work for mock builds and native builds on systemd based systems

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: use %initsystem check that works when chrooted

`systemctl' returns different, non-useful output while in a chroot.
Switch to checking if /sbin/init is a symlink to the systemd binary.
With this change the build works in a mock chroot.

Signed-off-by: Silas McCroskey <smccroskey@cumulusnetworks.com>

redhat: fix README for rpm package build

- correct requirements
- add comment on bison 2.7 installation on CentOS 6

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: redirect reload function in frr init script to restart if reload script is not installed (fixes systemctl restart)

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: fix duplicate Requires: line in spec file

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Fix BuildRequires for FRR/2.0 and duplicate /etc/frr/daemons

- add make & gcc
- remove autoconf and automake (not needed to build from src.rpm)
- fix texi2html version detection for case when no texi2html is installed (broke yum-builddep)
- fix duplicate listing of /etc/frr/daemons

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Update documentation for RPM build and usage

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: fix upgrade script (%postun), remove invalid mpls package selection (it's always built and auto detected), add ldpd

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Add frr.service file for redhat based systemd systems (using init script)

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: /etc/frr/daemons needs to be marked as no replace config to be save from overwriting

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Add (combined) init.d script for FRR with daemon selection based on /etc/frr/daemons

- Provide new frr init script
- Remove separate per-deamon init.d scripts

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

watchfrr: Remove the HAVE_CUMULUS around the watchfrr.started file. It's always useful

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Add python2 build requirement to pythontools sub package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Fix previously added centos6/redhat6 check

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Fix install (daemon selection) and make postun scripts compatible with fedora

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Always disable PIMd on CentOS 6 and RedHat 6 systems as they are too old to correctly support the protocol

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Move frr-reload python script to it's own sub package to avoid the python2 requirement for main frr package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Don't set file attributes for symlinks

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Fix ospf6d typo in frr.spec.in

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Fix dependencies for rpm package

- Add bison, flex & autoconf
- Remove systemd for systems without it (i.e. CentOS 6)
- Update doc to reflect dependencies

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Remove tab's with spaces in frr.spec.in to make it better readable

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

redhat: Replace tab's with spaces in README

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

ripngd: fix packet buffer memleak

Fix #668

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ospf6d: fix heap uaf

Fix #667

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ospfd: fix stack underflow

Fix #666

}:-)

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge branch 'master' of https://github.com/FRRouting/frr into pim_dev