vrrpd: interface tracking

* Dynamically bind interfaces when they become available
* Automatically start VRRP sessions when their interfaces are added or
  come up
* Automatically shut down VRRP sessions when their interfaces are
  deleted or go down
* Automatically unbind interfaces when they are deleted

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: better messaging for interface binds

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: skip binding interface after create

When automatically creating new VRRP instances, we don't need to try to
bind them to macvlan interfaces again. We only need to do that when we
got notified that a new interface came up and want an existing VRRP
instance to update its interface bindings.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: close sockets on shutdown

When shutting down a VRRP router, kill the sockets as well. Too
dangerous to try to reuse them.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: log addresses for autoconfig

When adding and removing addreses. log them. Also include a VRID tag
when autoconfiguring new instances.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix incorrect index for vrrp event names

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: update auto*, init scripts, etc

Add vrrpd to all the usual places daemons need to go

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix err messaging for ipv6 addr add

* Add newline to message
* Change pasted IPv4 to IPv6

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add support for configuration writing

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: remove ifindex from hash key computation

Ifindexes apparently change more often than one might expect and so are
not suitable for use in hash keys.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: set DSCP byte on adverts to CS6

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: properly retrieve pkt src address

* Fix null dereference when retrieving IPv6 source address
* Change IPv4 code path to use system-specified source address instead
  of the one delivered in the IPv4 raw header

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix bug in v6 autoconfiguration

Typo caused the IPv4 VRRP router to be shutdown instead of the IPv6 one,
and sometimes a crash.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: use debugging knobs

* Gate all debugging messages with the debugging system
* Simplify a bit of debugging where it was easy to do inline

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add debugging knobs

* Add control structures for debugging
* Add CLI commands for debugging

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: minor cosmetic fix for sh vrrp

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: set sockets to -1 after closing

This also fixes a bug where assigning the same address as a VIP twice
would succeed the second time even if it actually failed both times.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix missing \n in cli

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: autoconfig support, continued

* Add support for interface up/down + address add/del events when using
  autoconfigure mode
* Add autoconfig information to show command

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: allow creation of adverts with no addresses

Fuzz testing revealed a crash in which VRRPD tries to create an
advertisement packet with no IP addresses. Should never occur under
normal use but might as well patch.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: ingress pkt validation dbg cleanups

* Use proper format specifiers for some data
* Print the correct sizes when reporting IP size errors

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: don't restart when changing priority

Both master and backup should be able to react to priority changes
without requiring a restart.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: properly find iface in manual cfg mode

As a crutch, interface search when manually configuring VRRP on an
interface did a prefix match on the name of macvlan interfaces,
comparing its name to the name of the interface VRRP was configured on
in order to determine if the interface under question was a subinterface
of the configured interface. This is obviously fragile and prone to
failure. We now pass up parent interface info from Zebra so use that
instead to correctly deduce parent-child relationships.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: autoconfig support

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add cli for preempt mode

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: specify version when parsing vrrp packet

Move a bit more validation into vrrp_packet.c

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix skew time calculation

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: protodown macvlan in backup state

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add support for VRRPv2

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: better logging for advertisement rx

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: use ipaddr size macro

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add sizing macro to ipaddr.h

Useful for getting the size of the relevant data in the `ip` field of
struct ipaddr.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: use address cmp for priority tiebreak

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: check rx'd advertisement checksum

And retrieve source address, since we need it anyway.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: cleanup vrrp packet crafting code

* Prefix all packet functions with 'vrrp_pkt'
* Break out checksum computation into separate function
* Accept version field when building advertisements
* Update doc comments

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: use correct mtypes

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: handle address deletion, don't accept dupes

* Do nothing if user tries to add the same IP twice
* Implement deletion of IPs
* Deactivate virtual router if all IPs are deleted
* Deduplicate add / remove code

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: same VRID, different interface

Identify VRRP instances by the 2-tuple (ifp, vrid) instead of by VRID,
allowing the same instance to be configured on different interfaces.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix headers

* Add include guards where missing
* Add include guard comments where missing
* Fix copyright notices
* Sort includes

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: improve show vrrp

* Dump all relevant interface names for each instance
* Compact IPvX address display

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: send ND Router Advertisements

Send ND Router Advertisements when IPv6 VR is in Master state.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: send ICMPv6 Neighbor Advertisements

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add function to get iface link-local

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: allow searching for interfaces late

Break out code for assigning macvlan interface to a vrrp router into its
own function so it can be called multiple times. This allows bringing up
IPv4 and IPv6 at different times if all the interfaces are not created
yet.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: implement `no` variants of commands

Except removing v4/v6 addresses

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: unset active flag on shutdown

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix priority setting

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: disable multicast loopback

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: remove bad priority check

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix a few bad XFREEs

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: compute VRRPv3 checksum

Correctly compute VRRPv3 checksum. Pseudoheaders are used for both IPv4
and IPv6.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add internet checksum with pseudoheaders

Add convenience functions to compute the Internet checksum of a data
block, including a pseudoheader.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: bind sockets to interfaces

Bind Rx socket to inbound interface.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix ownership discovery and mcast OIF

* Look for virtual IP ownership on the parent of the macvlan, not the
  macvlan itself
* IPv4: bind socket to real IP of the macvlan parent, but transmit on
  the macvlan interface
* IPv6: bind socket to IPv6 link local of the macvlan interface

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: transition to master when adv timer expires

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: handle incoming advertisements

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add initial macvlan support

* Search for macvlan interfaces with the appropriate name and MAC
  address when starting up a new VRRP instance
* Split VRRP socket into two; one for Tx, one for Rx
* Bind Tx socket to the macvlan subinterface so our VRRP advertisements
  go out with the correct MAC address
* Send ARP requests from this macvlan subinterface
* Improve error messaging

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix memleak when sending advertisements

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: read and validate vrrp advertisements

* Validate IPvX headers and packet contents
* Remove filter of non-255 TTL IPv4 packets; better to receive, log and
  drop them ourselves
* Set outgoing packet TTL / hop limit to 255
* Use existing sockopt functions

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: ipv6 support

Add initial support for IPv6.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: elect self to Master when owning v4 address

If the primary address is v4, and we own the address on our configured
interface, set ourselves to Master.

This introduces the concept of a separate priority value used to store
the configured vs effective priority.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: handle rescheduling Adver_Timer, Shutdown

* Reschedule Adver_Timer when necessary
* Handle Shutdown event appropriately for all states

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: improve logging

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: implement advertisement send

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix packet encode

* Properly encode VRRP packets
* Calculate checksum appropriately
* Update signature to provide caller both packet and result length

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: merge keepalived packet header

Pick up some smartness from keepalived.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add list_to_array

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add unit when showing time values

Add 'cs' unit to end of centisecond values when displaying to user

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: fix more timer bugs

* Fix overflow in skew time computation
* Fix accidentally removed initial setting of advertisement interval

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: clean up configuration code, fix skew bug

* Update vrrp.[ch] file header to be more accurate
* Make vrrp_update_times() private again
* Add times reset function and use it
* Add priority and advertisement interval setter functions and use them
* Add command to change advertisement interval
* Allow showing all VRRP instances
* Improve doc comments on functions
* Add ability to shutdown router
* Reorganize vrrp.h
* Add doc comments to vrrp.h

* Fix bug where Skew_time was not used to compute Master_Down_Interval

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: config commands, enable ARP

* Allow configuring priority
* Allow configuring IPv4 addresses
* Add show command for vrouters
* Fix hash comparison function
* Fix ARP packetization bugs
* Enable sending of gratuitous ARP

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: get sockets working

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: zebra connections

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: interface support

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: add .gitignore

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: implement gratuitous ARP

Implement gratuitous ARP functionality. Ethernet only.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vrrpd: initial commit

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #4355 from donaldsharp/revert_rtadv_changes

Revert rtadv changes

Merge pull request #4354 from donaldsharp/more_gcc_9_1_werror

zebra: fix missed multipath_num change

Revert "zebra: move rtadv service from zrouter to zvrf"

This reverts commit f20e2a09c8aef399698fa074b36f24becdf49cbb.

Revert "zebra: keep rtadv_sock field in zrouter for optimisation"

This reverts commit 3738d700ff9aac5b7c4fed1a41dc47644488009f.

zebra: fix missed multipath_num change

The multipath_num global variable was moved into
zrouter.multipath_num but this particular usage
of it was not updated.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #4337 from donaldsharp/routemap_coverity

zebra: Make coverity SA happy with zebra_routemap.c

Merge pull request #4352 from donaldsharp/routemap_fix_replace

lib: Fix gcc 9.1 and --enable-werror issues found

Merge pull request #4219 from bisdhdh/biswajitfrr_5

bgpd: Implement 3rd party nexthop for ebgp ipv6 sender, when nexthop matches IPV6 address of the neighbor.

Merge pull request #4144 from pguibert6WIND/bfd_cbit

BFD CBIT

Merge pull request #4269 from donaldsharp/other_tables

zebra Other tables

Merge pull request #4313 from lkrishnamoor/overlay_json_cli

bgpd: json cli output for bgp evpn overlay

Merge pull request #4327 from sworleys/Move-Multipath-Num

zebra: Move multipath_num into zrouter

Merge pull request #4340 from qlyoung/hash-key-const

lib: hashing functions should take const arguments

Merge pull request #4339 from sworleys/Add-AFI_UNSPEC

lib,bgpd,pbrd: Add AFI_UNSPEC to AFI enum

Merge pull request #4316 from LabNConsulting/working/master/tt-scale-vrfs

bgp_l3vpn_to_bgp_vrf: test adding/removing 50K*2CEs VRF routes

lib: Fix gcc 9.1 and --enable-werror issues found

Compiling FRR w/ gcc 9.1 and --enable-werror generates some
issues that need to be cleaned up.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

doc/developer: topotest now compile should now enable sharpd, alos care most about master

Signed-off-by: Lou Berger <lberger@labn.net>

bgp_l3vpn_to_bgp_vrf: test adding/removing 50K*2CEs VRF routes
      Only runs when configured with --enable-sharpd

Signed-off-by: Lou Berger <lberger@labn.net>

bgp_l3vpn_to_bgp_vrf: disable bgp debug logging

Signed-off-by: Lou Berger <lberger@labn.net>

topotests/lib: support sharpd and other daemons in lutils
       needs both <daemon>.conf and <daemon> to be present

Signed-off-by: Lou Berger <lberger@labn.net>

Merge pull request #4341 from donaldsharp/bgp_attr_should_actually_compile

bgpd: Fix non-compilation of bgp_attr_extcom_tunnel_type

bgpd: Fix non-compilation of bgp_attr_extcom_tunnel_type

The bgp_attr_extcom_tunnel_type does not properly
compile with warnings turned on due to recent change.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #4296 from adharkar/frr-master-fib_prefix

Zebra: Add "show ip/ipv6 fib <prefix> [json]" CLI