Merge pull request #2448 from qlyoung/error-reference-cards

Error Reference Cards

Merge pull request #2845 from donaldsharp/cmsg_foolishness

lib, ripngd, zebra: Remove pre-solaris 9 special cased code

Merge pull request #2838 from opensourcerouting/bfd-alpine

bfdd: fix alpine build

lib, ripngd, zebra: Remove pre-solaris 9 special cased code

The CMSG_FIRSTHDR was broken on solaris pre version 9.  Version 9
was released in May of 2002 and EOL'ed in 2014.  Version 8 EOL'ed
in 2012.  Remove special case code for a little used platform
that has not seen the light of day in a very long time.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #2844 from donaldsharp/unused

bfdd: Fix `don't assign to value to ourself` compiler warning

bfdd: Fix `don't assign to value to ourself` compiler warning

We were attempting to get around a unused value by setting
a variable to itself, but it runs afoul of a different
compiler and a message about not setting a variable to
itself.  So let's mark the ttl value as unused.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #2837 from ppmathis/cidr-style

bgpd: Always show CIDR mask when displaying routes

Merge pull request #2840 from opensourcerouting/snap-bfdd

snapcraft: Add bfdd to snap package

Merge pull request #2843 from LabNConsulting/working/lb/doc-solo

bgpd: document how to avoid reflecting advertised information back to originator

user: document neighbor ... solo config

Signed-off-by: Lou Berger <lberger@labn.net>

bfdd: fix alpine build

Move `recvmsg` parameter option initialization to function, initialize
the parameter struct with zeroes and access field by name.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

bfdd: fix downtime display

BFD peer status show command was using the wrong variable to display the
downtime counter.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>

snapcraft: Add bfdd to snap package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

*: frr_elevate_privs whitespace fixes

(... and one superfluous variable removed)

Signed-off-by: David Lamparter <equinox@diac24.net>

zebra: fix warnings from frr_elevate_privs()

Signed-off-by: David Lamparter <equinox@diac24.net>

*: use frr_elevate_privs() (2/2: manual)

Signed-off-by: David Lamparter <equinox@diac24.net>

*: use frr_elevate_privs() (1/2: coccinelle)

Signed-off-by: David Lamparter <equinox@diac24.net>

lib: add frr_elevate_privs() wrapper

Used as:
  frr_elevate_privs(&my_privs) {
    ... code ...
  }
and handles privilege raise/lower automatically in conjunction with the
C expression block.  This makes it impossible to accidentally exit a
function with privileges raised (and then running a whole bunch of other
code with privs.)

Signed-off-by: David Lamparter <equinox@diac24.net>

*: rename ferr_zlog -> flog_err_sys

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: rename ferr_ref -> log_ref

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: rename zlog_fer -> flog_err

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: remove still reachable blocks in ferr.c

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib, vtysh: fixup style nits for error refs

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: add missing include

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: correct typos in error reference cards

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: Cleanup compile issues discovered by ci

Include a couple of missed headers.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

*: remove \n from error code texts

Should be handled by pager

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: add 'show error all json'

* Add 'all' option
* Add 'json' option

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

babeld: fix erroneous lib init

Babel was screwing up lib initialization causing double inits of many
things.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: stop double initialization of ferr

* Stop double init of ferr
* Fixup bugs in zebra ferr
* Add missing init in ospfd

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

*: fix source file headers & includes for errcodes

* Use the correct license header
* Stop headers from including themselves
* Use uniform relative include conventions
* Ensure that sources include what they use
* Turn off clang-format around struct array blocks

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ospfd: zlog_ferr facility

Ticket:CM-21333

Signed-off-by: Chirag Shah <chirag@cumulusnetworks.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Convert zlog_err for clippy build

The clippy code does not need to log the error messages
as errors as that it is only run as part of the build
itself and as long as we see the notifications we are good.

So convert zlog_err to zlog_notice so that we do not think
we have any zlog_err's in lib anymore

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Remove unnecessary zebra.h include

lib_errors.c does not need to include zebra.h, so remove

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ripd: Add RIP_ERR_XXX to move from zlog_err to zlog_ferr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

watchfrr: Add WATCHFRR_ERR_XXX for zlog_err to zlog_ferr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Fix Spelling mistake

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Add EIGRP_ERR_XXX for zlog_err to zlog_ferr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

nhrpd: Add NHRP_ERR_XXXX for zlog_err to zlog_ferr conversion

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Add some FLowspec specific Error Codes.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Convert to using LIB_ERR_XXX where possible

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra, lib: error references for zebra

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

isisd: Cleanup compile issue

cleanup compile with missnamed enum usage.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

isisd: Add isis_errors and generate custom Error Codes

Generate appropriate error codes for ISIS.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

isisd: Convert to use LIB_ERR_XXX

Where an obvious choice could be made about converting
to a LIB_ERR_XXX function do so.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

babeld: Convert all zlog_err to zlog_ferr and add appropriate info

Convert babeld to use zlog_ferr and add appropriate BABEL_ERR_XXX
information.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

babeld: Add BABEL_ERR_XXX error messages.

Add some BABEL_ERR_XXX error messages and convert over to using
zlog_ferr instead of zlog_err.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Add pim_errors and define some pim specific errors

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Cleanup initialization of bgp_errors.c

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: implement zlog_ferr facility for enhance error messages in bgp

Signed-off-by: Don Slice <dslice@cumulusnetworks.com<

ldpd: Convert to using LIB_ERR_XXX and zlog_ferr

convert ldpd over to using zlog_ferr and LIB_ERR_XXX
where appropriate.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Convert to use LIB_ERR_XXX for zlog_err

Convert, where appropriate, to using LIB_ERR_XXX for zlog_ferr

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Update error ranges to include all daemons

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

pimd: Convert over to use LIB_ERR_XXX for zlog_err

Convert, where appropriate, the zlog_err functions to zlog_ferr
for the LIB_ERR_XXX enums

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ripngd: Convert over to using LIB_ERR_XXXX for zlog_ferr

Convert over those zlog_err functions to zlog_ferr that
are appropriate for the LIB_ERR_XXX.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ripd: Convert zlog_err to zlog_ferr for LIB_ERR_XXX

For those errors that can be traced to LIB_ERR_XXX
convert to using those in ripd.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospf6d: Update OSPFv3 to use new zlog_ferr

Update OSPFv3 to use the new zlog_ferr messages

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Cleanup some missed LIB_ERR_SYSTEM_CALL

libfrr.c had some detection for system call issues.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_ZMQ

Add new error event for when we detect an issue within
the ZMQ subsystem.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_DEVELOPMENT

Sometimes a error state is detected when we have added
new code to FRR, but not updated all the places that
we should have.  Consider this a developmental escape
that needs to be fixed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_NS to error subsystem

Add additional information about NameSpace errors that
may happen.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib, zebra: Add LIB_ERR_INTERFACE

Add a error type that allows us to track bad interface states.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd, lib, zebra: Convert LIB_ERR_PRIVILEGES

For all the places we zlog_err about raising/lowering privileges, use
zlog_ferr.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_SNMP

Add code to indicate a SNMP error of some sort that needs to be
handled and addressed.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_VTY

Add a error code for when the vty subsystem detects
an error.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Add LIB_ERR_SYSTEM_CALL and convert VRF_SOCKET to SOCKET

Add a new error code LIB_ERR_SYSTEM_CALL to the ferr subsystem.
Additionally convert LIB_ERR_VRF_SOCKET to a more generic
LIB_ERR_SOCKET.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: When logging commands do not use zlog_err

When we are logging a commands via the `log commands`
cli, use zlog_notice instead of zlog_err, since that
this is not an actual error situation.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com.

lib: Convert to zlog_ferr for zclient.c

Convert the zclient.c file to use zlog_ferr.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib, bgpd: Add code to make lib auto create the ferr infrastructure

Add code to auto-create the ferr infrastructure as well as add
some initial error handling for vrf.c

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: Allow adding arrays of ferr's

Simplify addition of new messages to the system by allow passage of
arrays of data, instead of one at a time.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: add error reference system

* Add zlog_* function to log with a reference code
* Add ability to track reference cards for errors to ferr.[ch]
* Assign some reference code ranges

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

doc: Add missing flowspec.rst to distribution tar file

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

bgpd: Always show CIDR mask when displaying routes

Classful networking has been obsolete for ages and there is currently an
inconsistency between `show ip route` and `show bgp`, where the first
one always displays the CIDR mask while the second one hides classful
network masks.

This commit adjusts the behavior of `show bgp` to always show the CIDR
mask for a route, even when it is classful.

Signed-off-by: Pascal Mathis <mail@pascalmathis.com>

Merge pull request #2805 from opensourcerouting/malloc-size

lib: track total memory per MTYPE if possible

Merge pull request #2294 from opensourcerouting/bfd-final

bfdd: add BFD support

Merge branch 'master' into bfd-final

Merge pull request #2823 from opensourcerouting/snap-staticd

Updates to snap package to support staticd

Merge pull request #2833 from opensourcerouting/assorted-fixes

Assorted fixes (pre-northbound)

Merge pull request #2832 from opensourcerouting/rm-debug-leftovers

zebra: remove unguarded debugging leftovers

lib, vtysh: fix inconsistent interface commands in vtysh

The definition of the interface commands in vtysh.c were outdated.
Currently, all daemons that call if_cmd_init() will have the "no interface
IFNAME" command and the "[no] description" commands as well, so there's
no need to define exceptions for these commands anymore.

To fix this, make extract.pl parse the if.c file so that vtysh can get the
interface commands from there automatically. Only the "interface IFNAME
[vrf NAME]" must be kept in vtysh.c because it changes the vty node and
thus needs special treatment.

Finally, make pimd and pbrd display interface descriptions on "sh run"
when they are configured.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

lib, vtysh: fix inconsistent VRF commands in vtysh

* Only zebra and pimd call vrf_cmd_init(), so these are the only daemons
  that should receive VRF commands from vtysh;
* "netns NAME" and "no netns NAME" are available only in zebra, write
  custom DEFSHs in vtysh to make it aware of that;
* Remove the "no vrf NAME" definition from vtysh.c and expose the
  original command to vtysh by converting the DEFUN_NOSH to a simple
  DEFUN. This command doesn't change the vty node so there's no need to
  special case it.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

zebra: fix "no pseudowire IFNAME" on vtysh

We must hide only "pseudowire IFNAME" from vtysh, the "no" form of the
command should be made available to the extract.pl script. Split the
command into two to fix this problem.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

ldpd: use DEFPY_NOSH whenever possible

All ldpd commands were written using DEFPY except the ones that needed
to be ignored by vtysh, in which case we were using DEFUN_NOSH. Now that
DEFPY_NOSH is available, convert the remaining commands for consistency
and to simplify the code a little bit.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

lib: implement DEFPY_NOSH

This is the DEFPY equivalent of DEFUN_NOSH.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

babeld: avoid reading the configuration file twice

The frr_config_fork() function called by all FRR daemons during
initialization already takes care of reading the startup configuration
file.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

lib: add listnode_add_head()

Provide a new convenience function that adds an element to the beginning
of a list.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

snapcraft: Add new staticd to snap package

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

vtysh: Fix missing tailing / in --config_dir option parsing

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>

zebra: remove unguarded debugging leftovers

These debug messages were committed by accident.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

Merge pull request #2830 from pacovn/Coverity_1221459_revert

ospf6d: revert fix for Coverity 1221459

Merge pull request #2820 from opensourcerouting/err-prep

remove alloc return value checks + minor babeld cleanup

ospf6d: revert fix for Coverity 1221459

The correction in commit 7edb6aa (PR #2502) was wrong, as it is was not
taking in consideration the unlock counter. Thanks to @eqvinox for noticing
it.

Signed-off-by: F. Aragon <paco@voltanet.io>

Merge pull request #2827 from pacovn/Coverity_1472310_Unchecked_return_value

bgpd: return value check (Coverity 1472310)

Merge pull request #2828 from pacovn/Coverity_1472311_null_check

staticd: null check (Coverity 1472311)

Merge pull request #2825 from dslicenc/frr-reload-vni

tools: correct frr-reload.py handling of bgp vni/exit-vni config

Merge pull request #2824 from vishaldhingra/reg_case

peer_delete did not trigger ZEBRA_NEXTHOP_UNREGISTER to ZEBRA

staticd: null check (Coverity 1472311)

Signed-off-by: F. Aragon <paco@voltanet.io>

bgpd: return value check (Coverity 1472310)

Signed-off-by: F. Aragon <paco@voltanet.io>

peer_delete did not trigger ZEBRA_NEXTHOP_UNREGISTER to ZEBRA

bgp_unlink_nexthop_check() PEER should be NULL and bgp_info list count should be 0

Signed-off-by: vishaldhingra <vdhingra@vmware.com>

doc: Add missing flowspec.rst to distribution tar file

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>