lib: enforce thread_cancel() MT-unsafe invariant

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge remote-tracking branch 'origin/stable/3.0'

bgpd: Fix vrf crash

Ensure that we have a valid vrf before we log
information about it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>

ospf6d: Fix debug line always showing up in ospf6d

The command 'debug ospf6 lsa unknown' was
always showing up, upon starting of the ospf6 daemon.

Remove this from happening.  Also fix some help strings
while we are in there.

Ticket: CM-7913
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: More Extended nexthop fixing

Basically if we are reading in a cli with a extended-nexthop
and we have not received from zebra the interface we are working
on I believe we have a race condition where we are not
propagating the PEER_FLAG_CAPABILITY_ENHE in this case.

Modify the code to propagate even if we haven't found the
interface yet.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Fix ADJCHANGE message to include more info

When bgp logs ADJCHANGE messages include the
hostname and vrf that this change is being made
in.

Ticket: CM-10922
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Fix occassional turn off of extended-nexthop for an if

Sometimes, like once every 400 iterations, when you restart
Quagga, extended-nexthop has been turned off for interface
based config( for 5549 ).

Examining the code, there is only 1 real path to setting
the PEER_FLAG_CAPABILITITY_ENHE and that is through
peer_conf_interface_get.  Modify this code path
to always set the PEER_FLAG_CAPABILITY_ENHE if it is
not already set.

In addition, fix a possible pointer dereference.

Ticket: CM-12929
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Change Frr.conf to frr.conf

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Merge remote-tracking branch 'origin/stable/2.0'

Merge pull request #538 from qlyoung/fix-stack-access-2

lib: return thread * from thread_add*

Merge pull request #549 from qlyoung/fix-poll-eof

lib: correctly handle EOF when using poll()

Merge pull request #545 from donaldsharp/ospf_3.0_fixes

Ospf 3.0 fixes

Merge pull request #553 from donaldsharp/missed_2.0

Missed 2.0

Merge pull request #547 from donaldsharp/missed_pim_3.0

pimd: Fix core from json static mroute show

Merge pull request #532 from opensourcerouting/gpl-headers

*: make consistent & update GPLv2 file headers

bgpd: Fix vrf crash

Ensure that we have a valid vrf before we log
information about it.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>

ospf6d: Allow unconfig of unknown lsa's

When we are receiving the 'no debug ospf6 lsa unknown ...'
Allow the removal of the originate examine and flooding
keywords.

Ticket: CM-12805
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospf6d: Fix debug line always showing up in ospf6d

The command 'debug ospf6 lsa unknown' was
always showing up, upon starting of the ospf6 daemon.

Remove this from happening.  Also fix some help strings
while we are in there.

Ticket: CM-7913
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: More Extended nexthop fixing

Basically if we are reading in a cli with a extended-nexthop
and we have not received from zebra the interface we are working
on I believe we have a race condition where we are not
propagating the PEER_FLAG_CAPABILITY_ENHE in this case.

Modify the code to propagate even if we haven't found the
interface yet.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospfd: Fix possible crash and wrong data being shown

When you have more than one ospf interface configured
to be used, we were attempting to reuse the
json_interface_sub pointer after we added it
to the json data structure.

Ticket: CM-13597
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Fix ADJCHANGE message to include more info

When bgp logs ADJCHANGE messages include the
hostname and vrf that this change is being made
in.

Ticket: CM-10922
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: Fix occassional turn off of extended-nexthop for an if

Sometimes, like once every 400 iterations, when you restart
Quagga, extended-nexthop has been turned off for interface
based config( for 5549 ).

Examining the code, there is only 1 real path to setting
the PEER_FLAG_CAPABILITITY_ENHE and that is through
peer_conf_interface_get.  Modify this code path
to always set the PEER_FLAG_CAPABILITY_ENHE if it is
not already set.

In addition, fix a possible pointer dereference.

Ticket: CM-12929
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: correctly handle EOF when using poll()

Descriptor owner should handle EOF, not thread.c

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

pimd: Fix core from json static mroute show

When we have no normal mroutes and only static mroutes
there exists a code path where we attempted to dereference
c_oil when we were showing static mroutes.  Looks like
a cut-n-paste error, we should be using s_route->c_oil there

Ticket: CM-15013
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

lib: let vty.c manage its own pointers

vty.c doesn't require back refs for a couple threads

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: return thread pointer from thread_add*

Allow some more flexibility in case callers wish to manage their own
thread pointers and don't require or don't want the thread to keep a
back reference to its holding pointer.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge pull request #492 from dwalton76/stable/2.0

Change Frr.conf to frr.conf

ospfd: Actually fix ospf redistribute.

This is the final time I swear!

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

ospf6d: Fix 'no area .. range...' command

The cli uplift had confused some parameters.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #539 from donaldsharp/arm

Arm

lib: Improve error message for the developer

I keep getting people asking me about what to do
when this error is generated when they are programming
new cli.  Maybe this is a bit better bread-crumb?

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Fix arm compile issue with some gcc's

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

snapcraft: fix minor typo

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

snap: add vtysh as a "proper" command alias for frr.vtysh

   This allows direct access to vtysh without the "frr." prefix.
   The alias can be enabled by sudo snap frr vtysh

Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com>

lib: parser: remove forgotten line

MTYPE_CMD_TOKEN_DATA isn't used anymore, I forgot to ditch the line.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

*: make consistent & update GPLv2 file headers

The FSF's address changed, and we had a mixture of comment styles for
the GPL file header.  (The style with * at the beginning won out with
580 to 141 in existing files.)

Note: I've intentionally left intact other "variations" of the copyright
header, e.g. whether it says "Zebra", "Quagga", "FRR", or nothing.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #531 from qlyoung/fix-stack-ref

lib: fix access to stack value

doc: fix VARIABLE <> WORD confusion in cli.md

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd: autocomplete peer-groups & interface peers

This wasn't quite correct in the previous patch, leading to peer-groups
& interface peers breaking in autocompletion.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: cli: fix IPv6 address partial matching

A partially-entered IPv6 address would never return a "partly_match",
meaning some possible completions weren't listed by the matcher.

This specifically breaks autocompleting BGP IPv6 neighbor addresses.
Before:
aegaeon# show ip bg ne 2001:<?>
  WORD      Neighbor on BGP configured interface

After:
aegaeon# show ip bg ne 2001:<?>
  WORD      Neighbor on BGP configured interface
  X:X::X:X  Neighbor to display information about
      2001:db8::2

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

doc: update CLI documentation

Fix markdown formatting & add variable names.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

bgpd: autocomplete neighbor names

Add autocompletion for neighbor IP/IPv6/peer-group names.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

vtysh: autocomplete variables

This asks the connected daemons for their variable completions through a
hidden CLI command.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: cli: autocomplete variables

Shows known values in the appropriate naming domain when the user hits
<?> or <Tab>.  This patch only works in the telnet CLI, the next patch
adds vtysh support.

Included completions:
- interface names
- route-map names
- prefix-list names

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: parser: add pre-merge varname propagation step

Fills token->varname based on context.  WORD tokens use the WORD - if it
isn't actually "WORD".  Other than that, a preceding constant token is
used as name.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: parser: split off & rename graph handling

Put core CLI graph stuff in lib/command_graph.[ch] and consistently
prefix all function names with "cmd_".

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

lib: parser: add named variables in CLI

struct cmd_token now has a "varname" field which is derived from the
DEFUN's string definition.  It can be manually specified with "$name"
after some token, e.g. "foo WORD$var".  A later commit adds code to
automatically fill the value if nothing is specified.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

Merge pull request #520 from opensourcerouting/bgpd-fixes-master

bgpd: assorted fixes (master)

Merge pull request #527 from LabNConsulting/working/master/patch-set/issue471+473

Master: Restore label distribution for VPN safi

Merge pull request #526 from donaldsharp/renato_eigrp

Renato eigrp

lib: fix access to stack value

Passing stack value to thread_add_* causes thread->ref to become an
invalid pointer when the value goes out of scope

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Merge remote-tracking branch 'origin/stable/3.0'

bgpd: fix table leak introduced in labeled unicast (Issue #473)
      Fix tested for vpn and encap ribs/safi.  Labeled unicast
      may still leak as not tested.

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd: fix v6 encap safi config - more labeled unicast breakage (Issue #473)

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd: fix rfapi label origination (Issue #473)

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd: fix VPN SAFI label distribution (Issue #473)

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd: add epvn as labeled safi type (ISSUE #471)

Signed-off-by: Lou Berger <lberger@labn.net>

eigrpd: Diverse Fixes

* Correct the metric calculation as well as the default metrics;
* Do not show invalid routes in the "show ip eigrp topology".
* Add support to VRFs;
* When downloading a neighbor remove the related routes;
* Fix bugs in the parser of packages they were creating
Invalid default routes;
* Add and remove routes in the zebra;
* Add command "on router eigrp AS";
* Make "delay" and "bandwitch" commands work as well as
Display them in running config;
* Add "no" version of several commands;
* Fix a serious momory leaks;
* Fix segfault when there is no 'successor' route to a
Given prefix;
* Other minor corrections;

Signed-off-by: Renato Westphal <renatowestphal@gmail.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

eigrpd: Some Basic Corrections

* Advertise routes to zebra
* Connected routes should not have a nexthop address
* Fix segfaut on exit

Signed-off-by: Renato Westphal <renatowestphal@gmail.com>

lib: Cleanup command parsing a tiny bit

The CLI changes now make it impossible for numbers
outside the range specified in the cli to make it to
this code.  No need to check for it again.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #521 from opensourcerouting/bgpd-fixes-stable

bgpd: assorted fixes (stable/3.0)

Merge pull request #508 from LabNConsulting/working/3.0/patch/issue198

bgpd: Issue #198 - clean up duplicate encap SAFI commands

Merge pull request #525 from qlyoung/frr-script-fix

tools: $valgrind --> "$valgrind"

Merge pull request #524 from qlyoung/blublublub3.0

lib: use %p specifier for pointers

tools: $valgrind --> "$valgrind"

String cmp missing quotes

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: use %p specifier for pointers

Fixes builds on ARM

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

README: add references to EIGRP and NHRP.

Merge pull request #518 from dwalton76/zebra-mpls-lsp-uninstall

zebra: zebra_mpls_lsp_uninstall was not being called

Merge pull request #495 from donaldsharp/mpls_fixes

Mpls fixes

bgpd: fix segfault with '[no] bgp network import-check'

These commands were causing bgpd to crash if a static VPN route was
configured.

While here, fix a bug in bgp_static_add() and bgp_static_delete().

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: fix duplicate install of command

Only happens when FRR is configured with --enable-oldvpn-commands.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: fix 'show bgp [...] longer-prefixes'

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: remove unused bgp_attr_default_intern() function

This function is not used anymore since commit 137446f9.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

lib: remove gap between AFI_IP6 and AFI_L2VPN

We have several pieces of code like this in FRR:

  for (afi = AFI_IP; afi < AFI_MAX; afi++)
    for (safi = SAFI_UNICAST; safi < SAFI_MAX; safi++)
      bgp_distance_table[afi][safi] = bgp_table_init (afi, safi);

We were creating a lot of useless garbage in the code because of this
gap. Fix this.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: fix segfault with '[no] bgp network import-check'

These commands were causing bgpd to crash if a static VPN route was
configured.

While here, fix a bug in bgp_static_add() and bgp_static_delete().

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: fix duplicate install of command

Only happens when FRR is configured with --enable-oldvpn-commands.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: removed unused parameter from bgp_dump_attr()

Originally we used the 'peer' parameter for this:

  if (peer_sort (peer) == BGP_PEER_IBGP)
    snprintf (buf + strlen (buf), size - strlen (buf), ", localpref %d",
              attr->local_pref);

Now we have this:

  if (CHECK_FLAG (attr->flag, ATTR_FLAG_BIT (BGP_ATTR_LOCAL_PREF)))
    snprintf (buf + strlen (buf), size - strlen (buf), ", localpref %u",
              attr->local_pref);

Remove the now useless 'peer' parameter.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

lib: add labeled-unicast in safi2str()

While here, move SAFI_ENCAP above SAFI_MPLS_VPN to keep the ordering
consistent.

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

bgpd: fix 'show bgp [...] longer-prefixes'

Signed-off-by: Renato Westphal <renato@opensourcerouting.org>

zebra: zebra_mpls_lsp_uninstall was not being called

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Old entries were not being removed from the MPLS table.

Merge pull request #511 from donaldsharp/netlink_dump

zebra: Fix kernel netlink hex dump of information

zebra: Fix kernel netlink hex dump of information

1) Fix the kernel send and recv hex dump of what we
are sending to the kernel

2) When configuring the debugs under 'conf t' display
it too.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

Merge pull request #510 from opensourcerouting/update-tools-gitignore

tools: update .gitignore

tools: update .gitignore

Signed-off-by: Christian Franke <chris@opensourcerouting.org>

bgpd: Issue #198 - clean up duplicate command resulting from CLI refactoring

Signed-off-by: Lou Berger <lberger@labn.net>

bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI next
hop for EVPN

In the case of EVPN, add the nexthop attribute.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>

added troubleshooting section to debian 8 build doc

Merge pull request #505 from adamfitz/stable/2.0

added troubleshooting section to debian 8 build doc

Merge pull request #503 from pguibert6WIND/issue_473

bgpd: fixup bgpd: allow VPN next hop to be different AFI than NLRI nexthop for EVPN

Merge pull request #500 from qlyoung/fix-router-rip-3.0-3.0

vtysh: add \n to 'router rip[ng]' docstrings (3.0)

Merge pull request #496 from donaldsharp/vtysh_pager

*: Allow configure to control VTYSH_PAGER used

added troubleshooting section to debian 8 build doc

Merge pull request #502 from opensourcerouting/show-ip-fib

add 'show <ip|ipv6> fib' command

zebra: add 'show ipv6 fib' command

Signed-off-by: Christian Franke <chris@opensourcerouting.org>

zebra: add 'show ip fib' commands

Signed-off-by: Christian Franke <chris@opensourcerouting.org>

Address the error "Dead assignment" of static analysif

- Refer to https://ci1.netdef.org/browse/FRR-FRR4-44/artifact/shared/static_analysis/index.html
- Remove unused variable

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>

- Solve the Coverity Scan PW.ASSIGN_WHERE_COMPARE_MEANT

- Minor refactoring

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>

vtysh: add \n to 'router rip[ng]' docstrings

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

Address the error "Dead assignment" of static analysif

- Refer to https://ci1.netdef.org/browse/FRR-FRR4-44/artifact/shared/static_analysis/index.html
- Remove unused variable

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>

- Solve the Coverity Scan PW.ASSIGN_WHERE_COMPARE_MEANT

- Minor refactoring

Signed-off-by: Hung-Weic Chiu <sppsorrg@gmail.com>