lib: Clean up completions code, fix segfault on no match

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

tools: add copyright header & usage to permutations

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: allow nesting selectors

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

tools: add command permutations generator

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: explicitly support the case of empty input for completions

When the user tab- or ?-completes when the character prior to
the position of the cursor is a space, completion logic is
passed null. Explicitly handle this case instead of using
partly_match, which has special logic associated with it to
allow abbreviating certain tokens.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: Null-terminate tab completions char*[]

vtysh expects the result of a tab completion to
have a null pointer as the last element

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: Fix command execution npe

Caller may pass NULL if it does not care about what
command was matched.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: fix << in command strings

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

all: fix sundry syntax errors

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: Fix '?'-completion dereferences in vtysh

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: fix double free in parser

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib, vtysh: refactor vtysh.c, allow parser continuance

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: initialize cmd_vector and add a root node to graph

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

vtysh: fixed compile errors

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospfd: added some missing <>s

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

all: added some missing <>s within []s

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospfd: resolve argc CHECK MEs in ospf_vty.c

Signed-off-by: Don Slice <dslice@cumulusnetworks.com>

bgpd: combine special cases for vrf "all"

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: combine special cases for vrf "all"

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: clean up command string in CHECK ME comments

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

all: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

isisd: scrub argc CHECK ME's, refactor general

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

all: scrubbed some argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd and zebra: scrubbed argc CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

all: added CHECK ME for DEFUNs that look at argc

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospfd: minor parser fixes

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospfd: resolve CHECK ME's

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: change some <1-10> to (1-10>

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: finish all zebra CHECK ME's

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ripngd: finish CHECK ME's in ripngd

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ripngd: dispose of some CHECK ME's for ripng

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ripd: argv not argc

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ripd: resolve rip_routemap.c CHECK ME's

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

lib: reformat vty.h

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: fixed some bgp_routemap CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: fixed some bgp_routemap CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

isisd: resolve CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: remove unused variable

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Merge branch 'vtysh-grammar' of ssh://stash.cumulusnetworks.com:7999/quag/quagga into vtysh-grammar

pimd: removed undebug CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Merge branch 'vtysh-grammar' of ssh://stash.cumulusnetworks.com:7999/quag/quagga into vtysh-grammar

ripd, ripngd: cli refactor

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd, etc: changed .LINE to LINE...

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: fixed more CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: Put back missing code

When pulling forward the zebra_vty.c changes I accidently dropped
these changes from earlier commits.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Refactor 'no ipv6 route XXXX' for new cli

Refactor the 'no ipv6 route XXXX' commands to
work under the new cli and to collapse the code
to a much smaller set.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Refactor 'ipv6 route XXXX' for new cli

Take existing code for 'ipv6 route XXX' and
refactor to use the new cli.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Fixup 'no ip route....'

Rework the 'no ip route XXXX' commands to use the new cli
and collapse all DEFUN's that we could into a much smaller
set of commands.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

zebra: Refactore "ip route XXXXXX" commands

Convert all 'ip route XXXX' commands to use the new syntax and
collapse all functions that we can easily do.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

bgpd: compress "show ip bgp neighbor received prefix-list"

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: compress bgp_show_neighbor_route() calls

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: collaps show ip bgp, show ip bgp x.x.x.x, etc calls

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: bgp_vty.c compiles now

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: combine "show ip bgp summary" commands into one DEFUN

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: minor grammar corrections

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: combine "clear bgp, clear ip bgp" commands into one DEFUN

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Expand #defines in command strings

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Expand #defines in command strings

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>
Reviewed-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: Sam Tannous <stannous@cumulusnetworks.com>
Ticket:

Expand #defines in command strings

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: CHECK ME fixes

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: fixed more CHECK MEs in bgp_vty.c

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: refactor rtadv.c

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: refactor zserv.c

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: fix zebra_routemap.c checkme's

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

bgpd: fixed some CHECK MEs

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: added strmatch()

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: lib compiles

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

zebra: zebra_vty.c compiles

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Merge branch 'vtysh-grammar' of ssh://stash.cumulusnetworks.com:7999/quag/quagga into vtysh-grammar

lib: Implement removed ALIAS into DEFUN

N.B.: some of these are de-facto ALIAS resurrections
that are necessary due to some parser limitations; these
are marked with ALIAS_FIXME so I can go back and add
capability to the parser to handle these special cases.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>

ripd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ripngd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

pimd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospfd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

isisd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: add 'int idx_foo' argv index variables

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: fix vrf argv index numbers

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

zebra: compress multiple whitespaces in command string

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

bgpd: fix hosed CMD_RANGE_STR

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

convert <1-255> to (1-255), ()s to <>s, etc

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

tools: argv_translator convert <1-255> to (1-255), ()s to <>s, etc

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

Change {json} to [json]

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: undo <> -> () change I made yesterday

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

tools: alias_destroyer re_install_element None check

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ALIAS removal for bgp, ospf, pim, isis, rip, ripng, lib and zebra

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

tools: added alias_destroyer.py

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: argv update for distribute.c and ns.c

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

isisd: argv update

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

lib: argv update for filter.c, if_rmap.c keychain.c and plist.c

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ospf6d: argv update

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

pimd: argv update

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ripd: argv update

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

ripngd: argv update

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>