From: Mark Stapp <mjs@voltanet.io>
Date: Thu, 12 Nov 2020 21:27:31 +0000 (-0500)
Subject: bgpd: fix SA warning
X-Git-Tag: base_7.6~284^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F7513%2Fhead;p=mirror%2Ffrr.git

bgpd: fix SA warning

Fix a coverity warning about an obscure path involving labels.

Signed-off-by: Mark Stapp <mjs@voltanet.io>
---

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 9873057fa2..5e7bf3f626 100644
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -3538,6 +3538,9 @@ int bgp_update(struct peer *peer, const struct prefix *p, uint32_t addpath_id,
 	else
 		has_valid_label = bgp_is_valid_label(label);
 
+	if (has_valid_label)
+		assert(label != NULL);
+
 	/* The flag BGP_NODE_FIB_INSTALL_PENDING is for the following
 	 * condition :
 	 * Suppress fib is enabled