From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Thu, 31 Jan 2019 12:51:07 +0000 (-0500)
Subject: lib: snprintf to strlcpy in frr_pthread.c
X-Git-Tag: 7.1_pulled~284^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F3714%2Fhead;p=mirror%2Ffrr.git

lib: snprintf to strlcpy in frr_pthread.c

Convert to using strlcpy to erase those pesky little
gcc warnings->errors

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/lib/frr_pthread.c b/lib/frr_pthread.c
index fe18eb1051..d7f655271b 100644
--- a/lib/frr_pthread.c
+++ b/lib/frr_pthread.c
@@ -83,9 +83,9 @@ struct frr_pthread *frr_pthread_new(struct frr_pthread_attr *attr,
 	name = (name ? name : "Anonymous thread");
 	fpt->name = XSTRDUP(MTYPE_FRR_PTHREAD, name);
 	if (os_name)
-		snprintf(fpt->os_name, OS_THREAD_NAMELEN, "%s", os_name);
+		strlcpy(fpt->os_name, os_name, OS_THREAD_NAMELEN);
 	else
-		snprintf(fpt->os_name, OS_THREAD_NAMELEN, "%s", name);
+		strlcpy(fpt->os_name, name, OS_THREAD_NAMELEN);
 	/* initialize startup synchronization primitives */
 	fpt->running_cond_mtx = XCALLOC(
 		MTYPE_PTHREAD_PRIM, sizeof(pthread_mutex_t));