From: F. Aragon <paco@voltanet.io>
Date: Tue, 25 Sep 2018 15:54:09 +0000 (+0200)
Subject: isisd: out of bounds access (Coverity 1473286)
X-Git-Tag: frr-7.1-dev~322^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F3089%2Fhead;p=mirror%2Ffrr.git

isisd: out of bounds access (Coverity 1473286)

rawlspid_print(), which uses a fixed-width 8-byte input, has been replaced with
a call to isis_format_id(), allowing giving the input size.

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/isisd/isis_spf.c b/isisd/isis_spf.c
index 6a7528623c..42a019890f 100644
--- a/isisd/isis_spf.c
+++ b/isisd/isis_spf.c
@@ -1068,7 +1068,8 @@ static void isis_spf_loop(struct isis_spftree *spftree,
 		lsp = lsp_for_vertex(spftree, vertex);
 		if (!lsp) {
 			zlog_warn("ISIS-Spf: No LSP found for %s",
-				  rawlspid_print(vertex->N.id)); /* FIXME */
+				  isis_format_id(vertex->N.id,
+						 sizeof(vertex->N.id)));
 			continue;
 		}