From: David Lamparter <equinox@opensourcerouting.org>
Date: Sat, 8 Sep 2018 18:18:30 +0000 (+0200)
Subject: bfdd: fix garbage "port" string
X-Git-Tag: frr-7.1-dev~383^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F2994%2Fhead;p=mirror%2Ffrr.git

bfdd: fix garbage "port" string

bfd_recv_ipv4() is getting an uninitialized buffer passed in as port,
and then checks it without clearing it first.  Thus we can end up
leaving garbage data in it.

Signed-off-by: David Lamparter <equinox@diac24.net>
---

diff --git a/bfdd/bfd_packet.c b/bfdd/bfd_packet.c
index 4bdfb314e2..8acb9438c5 100644
--- a/bfdd/bfd_packet.c
+++ b/bfdd/bfd_packet.c
@@ -248,6 +248,8 @@ ssize_t bfd_recv_ipv4(int sd, uint8_t *msgbuf, size_t msgbuflen, uint8_t *ttl,
 	struct iovec iov[1];
 	uint8_t cmsgbuf[255];
 
+	port[0] = '\0';
+
 	/* Prepare the recvmsg params. */
 	iov[0].iov_base = msgbuf;
 	iov[0].iov_len = msgbuflen;