From: paco <paco@voltanet.io>
Date: Thu, 21 Jun 2018 10:09:44 +0000 (+0200)
Subject: vtysh: return value check (Coverity 1399200)
X-Git-Tag: frr-6.1-dev~261^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F2512%2Fhead;p=mirror%2Ffrr.git

vtysh: return value check (Coverity 1399200)

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c
index 309493b13e..a64e568daa 100644
--- a/vtysh/vtysh.c
+++ b/vtysh/vtysh.c
@@ -2634,8 +2634,13 @@ static void backup_config_file(const char *fbackup)
 	strcat(integrate_sav, CONF_BACKUP_EXT);
 
 	/* Move current configuration file to backup config file. */
-	unlink(integrate_sav);
-	rename(fbackup, integrate_sav);
+	if (unlink(integrate_sav) != 0) {
+		vty_out(vty, "Warning: %s unlink failed\n", integrate_sav);
+	}
+	if (rename(fbackup, integrate_sav) != 0) {
+		vty_out(vty, "Error renaming %s to %s\n", fbackup,
+			integrate_sav);
+	}
 	free(integrate_sav);
 }