From: paco <paco@voltanet.io>
Date: Fri, 15 Jun 2018 14:54:09 +0000 (+0200)
Subject: lib: out-of-bounds access (Coverity 1452539)
X-Git-Tag: frr-6.1-dev~243^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F2463%2Fhead;p=mirror%2Ffrr.git

lib: out-of-bounds access (Coverity 1452539)

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/lib/sbuf.c b/lib/sbuf.c
index 37c1e5283d..03a2be3e09 100644
--- a/lib/sbuf.c
+++ b/lib/sbuf.c
@@ -63,13 +63,12 @@ void sbuf_push(struct sbuf *buf, int indent, const char *format, ...)
 	int written;
 
 	if (!buf->fixed) {
-		char dummy;
 		int written1, written2;
 		size_t new_size;
 
-		written1 = snprintf(&dummy, 0, "%*s", indent, "");
+		written1 = indent;
 		va_start(args, format);
-		written2 = vsnprintf(&dummy, 0, format, args);
+		written2 = vsnprintf(NULL, 0, format, args);
 		va_end(args);
 
 		new_size = buf->size;