From: paco <paco@voltanet.io>
Date: Wed, 13 Jun 2018 16:07:36 +0000 (+0200)
Subject: tools: return check (Coverity 1143220)
X-Git-Tag: frr-6.1-dev~325^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F2436%2Fhead;p=mirror%2Ffrr.git

tools: return check (Coverity 1143220)

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/tools/start-stop-daemon.c b/tools/start-stop-daemon.c
index 6bf55b7740..4758d20666 100644
--- a/tools/start-stop-daemon.c
+++ b/tools/start-stop-daemon.c
@@ -1030,8 +1030,10 @@ int main(int argc, char **argv)
 		umask(022);    /* set a default for dumb programs */
 		setpgid(0, 0); /* set the process group */
 		fd = open("/dev/null", O_RDWR); /* stdin */
-		dup(fd);			/* stdout */
-		dup(fd);			/* stderr */
+		if (fd >= 0) {
+			dup(fd);		/* stdout */
+			dup(fd);		/* stderr */
+		}
 	}
 	if (nicelevel) {
 		errno = 0;