From: paco Date: Wed, 13 Jun 2018 15:24:51 +0000 (+0200) Subject: ospfd: buffer termination (Coverity 1464993) X-Git-Tag: frr-6.1-dev~322^2 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F2435%2Fhead;p=mirror%2Ffrr.git ospfd: buffer termination (Coverity 1464993) Signed-off-by: F. Aragon --- diff --git a/ospfd/ospf_ext.c b/ospfd/ospf_ext.c index ac5df3eb4e..331cba44a8 100644 --- a/ospfd/ospf_ext.c +++ b/ospfd/ospf_ext.c @@ -1125,7 +1125,7 @@ static int ospf_ext_pref_lsa_originate1(struct ospf_area *area, if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { char area_id[INET_ADDRSTRLEN]; - strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); + inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id)); zlog_debug( "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " "Extended Prefix Opaque LSA: Area(%s), Link(%s)", @@ -1175,7 +1175,7 @@ static int ospf_ext_link_lsa_originate1(struct ospf_area *area, if (IS_DEBUG_OSPF(lsa, LSA_GENERATE)) { char area_id[INET_ADDRSTRLEN]; - strncpy(area_id, inet_ntoa(area->area_id), INET_ADDRSTRLEN); + inet_ntop(AF_INET, &area->area_id, area_id, sizeof(area_id)); zlog_debug( "EXT (%s): LSA[Type%u:%s]: Originate Opaque-LSA " "Extended Link Opaque LSA: Area(%s), Link(%s)",