From: Rafael Zalamena <rzalamena@opensourcerouting.org>
Date: Wed, 31 Jul 2024 13:18:47 +0000 (-0300)
Subject: pimd: fix possible NULL dereference
X-Git-Tag: base_10.2~222^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F16509%2Fhead;p=mirror%2Ffrr.git

pimd: fix possible NULL dereference

Coverity scan ID: 1598684

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
---

diff --git a/pimd/pim_cmd.c b/pimd/pim_cmd.c
index dcfad2a4f8..f57048c703 100644
--- a/pimd/pim_cmd.c
+++ b/pimd/pim_cmd.c
@@ -2837,13 +2837,14 @@ DEFPY(clear_ip_msdp_peer, clear_ip_msdp_peer_cmd,
 	const struct vrf *vrf;
 	struct pim_msdp_peer *mp;
 
-	if (vrfname) {
+	if (vrfname)
 		vrf = vrf_lookup_by_name(vrfname);
-		if (vrf == NULL)
-			return CMD_WARNING;
-	} else
+	else
 		vrf = vrf_lookup_by_id(VRF_DEFAULT);
 
+	if (vrf == NULL || vrf->info == NULL)
+		return CMD_WARNING;
+
 	pim = vrf->info;
 	for (ALL_LIST_ELEMENTS_RO(pim->msdp.peer_list, node, mp)) {
 		if (mp->peer.s_addr != peer.s_addr)