From: Mark Stapp <mjs@labn.net>
Date: Mon, 10 Jul 2023 21:06:17 +0000 (-0400)
Subject: isisd: replace gmtime with gmtime_r
X-Git-Tag: base_9.1~271^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F13975%2Fhead;p=mirror%2Ffrr.git

isisd: replace gmtime with gmtime_r

No gmtime() allowed - use gmtime_r()

Signed-off-by: Mark Stapp <mjs@labn.net>
---

diff --git a/isisd/isis_misc.c b/isisd/isis_misc.c
index 09ffa3479a..e4ef6c8dfa 100644
--- a/isisd/isis_misc.c
+++ b/isisd/isis_misc.c
@@ -474,20 +474,20 @@ void log_multiline(int priority, const char *prefix, const char *format, ...)
 
 char *log_uptime(time_t uptime, char *buf, size_t nbuf)
 {
-	struct tm *tm;
+	struct tm tm;
 	time_t difftime = time(NULL);
 	difftime -= uptime;
-	tm = gmtime(&difftime);
+	gmtime_r(&difftime, &tm);
 
 	if (difftime < ONE_DAY_SECOND)
-		snprintf(buf, nbuf, "%02d:%02d:%02d", tm->tm_hour, tm->tm_min,
-			 tm->tm_sec);
+		snprintf(buf, nbuf, "%02d:%02d:%02d", tm.tm_hour, tm.tm_min,
+			 tm.tm_sec);
 	else if (difftime < ONE_WEEK_SECOND)
-		snprintf(buf, nbuf, "%dd%02dh%02dm", tm->tm_yday, tm->tm_hour,
-			 tm->tm_min);
+		snprintf(buf, nbuf, "%dd%02dh%02dm", tm.tm_yday, tm.tm_hour,
+			 tm.tm_min);
 	else
-		snprintf(buf, nbuf, "%02dw%dd%02dh", tm->tm_yday / 7,
-			 tm->tm_yday - ((tm->tm_yday / 7) * 7), tm->tm_hour);
+		snprintf(buf, nbuf, "%02dw%dd%02dh", tm.tm_yday / 7,
+			 tm.tm_yday - ((tm.tm_yday / 7) * 7), tm.tm_hour);
 
 	return buf;
 }