From: Christian Hopps <chopps@labn.net>
Date: Fri, 17 Jun 2022 06:04:51 +0000 (-0400)
Subject: lib: cleanup red-herring memleaks in parent of daemonizing fork
X-Git-Tag: base_8.4~342^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F11425%2Fhead;p=mirror%2Ffrr.git

lib: cleanup red-herring memleaks in parent of daemonizing fork

- The parent of the daemonizing fork reports memleaks for the early
northbound allocations (libyang). If these were real memleaks these
would show up in the child as well; however, ignoring all memleaks in
the parent of the fork is too hard a sale. Instead, spend some CPU
cycles cleaning up the allocations in the parent after the fork and
immeidatley prior to exiting the parent after the daemonizing fork.

Signed-off-by: Christian Hopps <chopps@labn.net>
---

diff --git a/lib/libfrr.c b/lib/libfrr.c
index 042c9d3704..f5aecd9f75 100644
--- a/lib/libfrr.c
+++ b/lib/libfrr.c
@@ -963,6 +963,8 @@ static void frr_daemonize(void)
 	}
 
 	close(fds[1]);
+	nb_terminate();
+	yang_terminate();
 	frr_daemon_wait(fds[0]);
 }