From: Donald Sharp <sharpd@nvidia.com>
Date: Mon, 14 Mar 2022 19:51:13 +0000 (-0400)
Subject: pimd: A wrong address family means the register-stop receive fails
X-Git-Tag: pim6-testing-20220430~207^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F10792%2Fhead;p=mirror%2Ffrr.git

pimd: A wrong address family means the register-stop receive fails

The current code in pim_register_stop_recv would never fail as
that the code was always returning 0 in all cases, but
if the code parses an incorrect afi then it has failed and
should return as much

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/pimd/pim_register.c b/pimd/pim_register.c
index 4bd0842017..7fa36e5a44 100644
--- a/pimd/pim_register.c
+++ b/pimd/pim_register.c
@@ -153,7 +153,7 @@ int pim_register_stop_recv(struct interface *ifp, uint8_t *buf, int buf_size)
 
 	if (wrong_af) {
 		zlog_err("invalid AF in Register-Stop on %s", ifp->name);
-		return 0;
+		return -1;
 	}