From: David Lamparter <equinox@opensourcerouting.org>
Date: Tue, 29 Aug 2017 19:08:55 +0000 (+0200)
Subject: ospf6d: fix prefix list name SEGV
X-Git-Tag: frr-4.0-dev~360^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=refs%2Fpull%2F1074%2Fhead;p=mirror%2Ffrr.git

ospf6d: fix prefix list name SEGV

Oops, I tested this with prefix lists configured and failed to notice it
blows up when nothing is set...

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
---

diff --git a/ospf6d/ospf6_area.c b/ospf6d/ospf6_area.c
index 649d7a1000..485937d882 100644
--- a/ospf6d/ospf6_area.c
+++ b/ospf6d/ospf6_area.c
@@ -643,9 +643,9 @@ void ospf6_area_plist_update(struct prefix_list *plist, int add)
 	const char *name = prefix_list_name(plist);
 
 	for (ALL_LIST_ELEMENTS_RO(ospf6->area_list, n, oa)) {
-		if (!strcmp(PREFIX_NAME_IN(oa), name))
+		if (PREFIX_NAME_IN(oa) && !strcmp(PREFIX_NAME_IN(oa), name))
 			PREFIX_LIST_IN(oa) = add ? plist : NULL;
-		if (!strcmp(PREFIX_NAME_OUT(oa), name))
+		if (PREFIX_NAME_OUT(oa) && !strcmp(PREFIX_NAME_OUT(oa), name))
 			PREFIX_LIST_OUT(oa) = add ? plist : NULL;
 	}
 }