From: Rafael Zalamena <rzalamena@opensourcerouting.org>
Date: Thu, 19 Jan 2023 13:42:01 +0000 (-0300)
Subject: lib: remove dead logic code
X-Git-Tag: base_8.5~52^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=ff9232c83bad982838e68fc0f9b7fbe8f77e0e02;p=matthieu%2Ffrr.git

lib: remove dead logic code

If we got inside the condition of `vrfp->status == VRF_ACTIVE` then
don't make the same check again.

Found by Coverity Scan (CID 1519760)

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
---

diff --git a/lib/vrf.c b/lib/vrf.c
index 5878c1734f..2ac7ef7a97 100644
--- a/lib/vrf.c
+++ b/lib/vrf.c
@@ -1000,8 +1000,7 @@ lib_vrf_state_active_get_elem(struct nb_cb_get_elem_args *args)
 	struct vrf *vrfp = (struct vrf *)args->list_entry;
 
 	if (vrfp->status == VRF_ACTIVE)
-		return yang_data_new_bool(
-			args->xpath, vrfp->status == VRF_ACTIVE ? true : false);
+		return yang_data_new_bool(args->xpath, true);
 
 	return NULL;
 }