From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Tue, 6 Sep 2022 08:49:08 +0000 (+0300)
Subject: bgpd: Do not forget to unlock bgp_dest from update_advertise_vni_routes
X-Git-Tag: base_8.4~58^2~4
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=fd43ffd97476b7e9367fb324184f33da9c91b268;p=matthieu%2Ffrr.git

bgpd: Do not forget to unlock bgp_dest from update_advertise_vni_routes

If "unexpected" happens.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/bgpd/bgp_evpn.c b/bgpd/bgp_evpn.c
index dc15d9c695..58f5e9a226 100644
--- a/bgpd/bgp_evpn.c
+++ b/bgpd/bgp_evpn.c
@@ -3631,8 +3631,10 @@ static int update_advertise_vni_routes(struct bgp *bgp, struct bgpevpn *vpn)
 			    pi->type == ZEBRA_ROUTE_BGP
 			    && pi->sub_type == BGP_ROUTE_STATIC)
 				break;
-		if (!pi) /* unexpected */
+		if (!pi) {
+			bgp_dest_unlock_node(dest);
 			return 0;
+		}
 		attr = pi->attr;
 
 		global_dest = bgp_global_evpn_node_get(bgp->rib[afi][safi],