From: Martin Winter Date: Fri, 10 Feb 2017 09:51:57 +0000 (+0700) Subject: vtysh: Fix Coverity Warning CID 1399479 (#1 of 1): Destination buffer too small ... X-Git-Tag: frr-2.0-rc2~5^2~3 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=fa389c272f944d15f31bb21d6d1ab0c53877f30c;p=matthieu%2Ffrr.git vtysh: Fix Coverity Warning CID 1399479 (#1 of 1): Destination buffer too small (BUFFER_SIZE) Coverity: buffer_size: You might overrun the 108 byte destination string addr.sun_path by writing the maximum 4095 bytes from path. Signed-off-by: Martin Winter --- diff --git a/vtysh/vtysh.c b/vtysh/vtysh.c index 7546b4ddb0..1b0dd8cd29 100644 --- a/vtysh/vtysh.c +++ b/vtysh/vtysh.c @@ -3001,7 +3001,7 @@ vtysh_connect (struct vtysh_client *vclient) memset (&addr, 0, sizeof (struct sockaddr_un)); addr.sun_family = AF_UNIX; - strncpy (addr.sun_path, path, strlen (path)); + strlcpy (addr.sun_path, path, sizeof (addr.sun_path)); #ifdef HAVE_STRUCT_SOCKADDR_UN_SUN_LEN len = addr.sun_len = SUN_LEN(&addr); #else