From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Fri, 22 Nov 2019 00:00:11 +0000 (-0500)
Subject: bgpd: remove extra ecom attr ptr increment
X-Git-Tag: frr-7.2.1~1^2~12
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f7704ce3b4f0f6511833b56ca0a5bd9148f63297;p=mirror%2Ffrr.git

bgpd: remove extra ecom attr ptr increment

Copy paste leads to invalid read of 1 byte off the heap when converting
extended community attributes into strings.

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/bgpd/bgp_ecommunity.c b/bgpd/bgp_ecommunity.c
index 850b85aa6a..0b96748c38 100644
--- a/bgpd/bgp_ecommunity.c
+++ b/bgpd/bgp_ecommunity.c
@@ -822,7 +822,6 @@ char *ecommunity_ecom2str(struct ecommunity *ecom, int format, int filter)
 				   == ECOMMUNITY_EVPN_SUBTYPE_ES_IMPORT_RT) {
 				struct ethaddr mac;
 
-				pnt++;
 				memcpy(&mac, pnt, ETH_ALEN);
 				len = sprintf(
 					str_buf + str_pnt,