From: Quentin Young <qlyoung@nvidia.com>
Date: Wed, 23 Sep 2020 19:37:48 +0000 (-0400)
Subject: pimd, zebra: explicit cast int netlink val to uint
X-Git-Tag: base_8.0~83^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f3aa221ffd0f7a68790fad71c8d7af00a34cea22;p=mirror%2Ffrr.git

pimd, zebra: explicit cast int netlink val to uint

encoding signed int as unsigned is bad practice; since we want to do
it here lets at least be explicit about it

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
---

diff --git a/pimd/pim_zlookup.c b/pimd/pim_zlookup.c
index 05c9af8734..72505a6993 100644
--- a/pimd/pim_zlookup.c
+++ b/pimd/pim_zlookup.c
@@ -600,7 +600,8 @@ int pim_zlookup_sg_statistics(struct channel_oil *c_oil)
 	}
 
 	stream_get(&lastused, s, sizeof(lastused));
-	stream_getl(s);
+	/* signed success value from netlink_talk; currently unused */
+	(void)stream_getl(s);
 
 	c_oil->cc.lastused = lastused;
 
diff --git a/zebra/zebra_mroute.c b/zebra/zebra_mroute.c
index 3af805558d..ef0f2d8924 100644
--- a/zebra/zebra_mroute.c
+++ b/zebra/zebra_mroute.c
@@ -65,7 +65,7 @@ stream_failure:
 	stream_put_in_addr(s, &mroute.sg.src);
 	stream_put_in_addr(s, &mroute.sg.grp);
 	stream_put(s, &mroute.lastused, sizeof(mroute.lastused));
-	stream_putl(s, suc);
+	stream_putl(s, (uint32_t)suc);
 
 	stream_putw_at(s, 0, stream_get_endp(s));
 	zserv_send_message(client, s);