From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Thu, 31 May 2018 13:37:34 +0000 (-0400)
Subject: bgpd: Fix SA issue with uninited ifindex value
X-Git-Tag: frr-6.1-dev~394^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f220da9968741598ef224cdaf66a131026498a64;p=matthieu%2Ffrr.git

bgpd: Fix SA issue with uninited ifindex value

The rearrangement of where the decision point of
filling in the aggregate information, must have allowed
SA to find a path of code where we may use ifindex uninitialized.
While I don't think this is possible to happen, make this issue
go away.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/bgpd/bgp_zebra.c b/bgpd/bgp_zebra.c
index e4f4823e6f..1cd51cb6f4 100644
--- a/bgpd/bgp_zebra.c
+++ b/bgpd/bgp_zebra.c
@@ -1316,7 +1316,7 @@ void bgp_zebra_announce(struct bgp_node *rn, struct prefix *p,
 					&mpinfo_cp->attr->nexthop,
 					mpinfo_cp->attr, is_evpn, api_nh);
 		} else {
-			ifindex_t ifindex;
+			ifindex_t ifindex = IFINDEX_INTERNAL;
 			struct in6_addr *nexthop;
 
 			if (bgp->table_map[afi][safi].name) {