From: Sai Gomathi N <nsaigomathi@vmware.com>
Date: Thu, 27 Oct 2022 08:52:31 +0000 (-0700)
Subject: pimd: Unchecked return value
X-Git-Tag: base_8.5~297^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f13530f23a9ba73027f8f40b78eb81396afaa092;p=mirror%2Ffrr.git

pimd: Unchecked return value

In tib_sg_oil_setup: Value returned from a function is not checked for errors before being used.
If the function returns an error value, the error value may be mistaken for a normal value.
Here, only the nexthop value is being used. So casted the return type to void.

Coverity CID-1519816

Signed-off-by: Sai Gomathi N <nsaigomathi@vmware.com>
---

diff --git a/pimd/pim_tib.c b/pimd/pim_tib.c
index 8f5de3e938..3455e30064 100644
--- a/pimd/pim_tib.c
+++ b/pimd/pim_tib.c
@@ -49,7 +49,8 @@ tib_sg_oil_setup(struct pim_instance *pim, pim_sgaddr sg, struct interface *oif)
 	if (up) {
 		memcpy(&nexthop, &up->rpf.source_nexthop,
 		       sizeof(struct pim_nexthop));
-		pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp, 0);
+		(void)pim_ecmp_nexthop_lookup(pim, &nexthop, vif_source, &grp,
+					      0);
 		if (nexthop.interface)
 			input_iface_vif_index = pim_if_find_vifindex_by_ifindex(
 				pim, nexthop.interface->ifindex);