From: Donald Sharp Date: Wed, 15 Aug 2018 17:48:09 +0000 (-0400) Subject: bfdd: Fix `don't assign to value to ourself` compiler warning X-Git-Tag: frr-6.1-dev~64^2 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f0d2be33170ba78ca7cd31d4dc11b880f372aa32;p=mirror%2Ffrr.git bfdd: Fix `don't assign to value to ourself` compiler warning We were attempting to get around a unused value by setting a variable to itself, but it runs afoul of a different compiler and a message about not setting a variable to itself. So let's mark the ttl value as unused. Signed-off-by: Donald Sharp --- diff --git a/bfdd/ptm_adapter.c b/bfdd/ptm_adapter.c index ca44be6541..9a2b70d36a 100644 --- a/bfdd/ptm_adapter.c +++ b/bfdd/ptm_adapter.c @@ -286,7 +286,7 @@ static int _ptm_msg_read(struct stream *msg, int command, struct bfd_peer_cfg *bpc, struct ptm_client **pc) { uint32_t pid; - uint8_t ttl; + uint8_t ttl __attribute__((unused)); uint8_t ifnamelen; /* @@ -360,12 +360,6 @@ static int _ptm_msg_read(struct stream *msg, int command, /* Read multihop source address and TTL. */ _ptm_msg_read_address(msg, &bpc->bpc_local); STREAM_GETC(msg, ttl); - - /* - * TODO: use TTL for something. The line below removes - * an unused variable compiler warning. - */ - ttl = ttl; } else { /* If target is IPv6, then we must obtain local address. */ if (bpc->bpc_ipv4 == false)