From: Donatas Abraitis <donatas@opensourcerouting.org>
Date: Sat, 13 Apr 2024 19:41:43 +0000 (+0300)
Subject: ospfd: Fix compile warning with `-Wformat-truncation`
X-Git-Tag: base_10.1~184^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=f003ccf16b141836758183a3f9f984f970289a7a;p=mirror%2Ffrr.git

ospfd: Fix compile warning with `-Wformat-truncation`

ospfd/ospf_sr.c: In function ‘show_sr_node.part.5’:
ospfd/ospf_sr.c:2745:32: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 2 [-Wformat-truncation=]
    snprintf(tmp, sizeof(tmp), "%u", i);
                                ^~
ospfd/ospf_sr.c:2745:31: note: directive argument in the range [0, 2147483646]
    snprintf(tmp, sizeof(tmp), "%u", i);

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
---

diff --git a/ospfd/ospf_sr.c b/ospfd/ospf_sr.c
index e26fe6f53a..198309c1ef 100644
--- a/ospfd/ospf_sr.c
+++ b/ospfd/ospf_sr.c
@@ -2740,9 +2740,9 @@ static void show_sr_node(struct vty *vty, struct json_object *json,
 			if (srn->algo[i] == SR_ALGORITHM_UNSET)
 				continue;
 			json_obj = json_object_new_object();
-			char tmp[2];
+			char tmp[12];
 
-			snprintf(tmp, sizeof(tmp), "%u", i);
+			snprintf(tmp, sizeof(tmp), "%d", i);
 			json_object_string_add(json_obj, tmp,
 					       srn->algo[i] == SR_ALGORITHM_SPF
 						       ? "SPF"