From: Donald Sharp <sharpd@nvidia.com>
Date: Thu, 9 Sep 2021 13:02:12 +0000 (-0400)
Subject: pathd: Ensure node_src_id is inited before usage
X-Git-Tag: base_8.1~86^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=e81a74a64255913e529455ff16ab1f64ea1cca39;p=matthieu%2Ffrr.git

pathd: Ensure node_src_id is inited before usage

Compiler is warning that node_src_id may be used uninited
we know this is not possible but the compiler doesn't.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/pathd/path_cli.c b/pathd/path_cli.c
index bd629a2b70..46242fd05a 100644
--- a/pathd/path_cli.c
+++ b/pathd/path_cli.c
@@ -352,7 +352,16 @@ static int segment_list_has_src_dst(
 		nb_cli_enqueue_change(vty, xpath, NB_OP_MODIFY,
 				      "ipv6_adjacency");
 		node_src_id = adj_src_ipv6_str;
+	} else {
+		/*
+		 * This is just to make the compiler happy about
+		 * node_src_id not being initialized.  This
+		 * should never happen unless we change the cli
+		 * function.
+		 */
+		assert(!"We must have a adj_src_ipv4_str or a adj_src_ipv6_str");
 	}
+
 	/* addresses */
 	snprintf(xpath, XPATH_MAXLEN, "./segment[index='%s']/nai/local-address",
 		 index_str);