From: Philippe Guibert Date: Mon, 7 Nov 2022 10:03:41 +0000 (+0100) Subject: ospfd: prevent from crashing when processing external lsa X-Git-Tag: base_8.5~255^2 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=e5309c1a6e366f5dc95cbc3bbbe5c7ce1d46625c;p=matthieu%2Ffrr.git ospfd: prevent from crashing when processing external lsa When using debug mode, the ei parameter may be NULL. In that case, do not display the log trace, otherwise a crash will happen. Signed-off-by: Philippe Guibert --- diff --git a/ospfd/ospf_lsa.c b/ospfd/ospf_lsa.c index 4fb3a33568..a67b6c6c19 100644 --- a/ospfd/ospf_lsa.c +++ b/ospfd/ospf_lsa.c @@ -2205,7 +2205,7 @@ struct ospf_lsa *ospf_external_lsa_originate(struct ospf *ospf, */ if (ospf->router_id.s_addr == INADDR_ANY) { - if (IS_DEBUG_OSPF_EVENT) + if (ei && IS_DEBUG_OSPF_EVENT) zlog_debug( "LSA[Type5:%pI4]: deferring AS-external-LSA origination, router ID is zero", &ei->p.prefix); @@ -2214,7 +2214,7 @@ struct ospf_lsa *ospf_external_lsa_originate(struct ospf *ospf, /* Create new AS-external-LSA instance. */ if ((new = ospf_external_lsa_new(ospf, ei, NULL)) == NULL) { - if (IS_DEBUG_OSPF_EVENT) + if (ei && IS_DEBUG_OSPF_EVENT) zlog_debug( "LSA[Type5:%pI4]: Could not originate AS-external-LSA", &ei->p.prefix);