From: Donald Sharp Date: Fri, 6 Sep 2019 12:46:27 +0000 (-0400) Subject: tests: Ensure we wait 1 bgp timeout period before declaring failure X-Git-Tag: base_7.3~383^2 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=dfff0ef449569374391ef04cab59c1d5b94e04d7;p=matthieu%2Ffrr.git tests: Ensure we wait 1 bgp timeout period before declaring failure The lib/bgp.py test code is bringing up neighbors and clearing them to test that things are working appropriately. The problem we have is that we are only waiting 30 seconds for declaration of failure. In a high load system packets can be lost and as such the initial convergence may not happen. Modify the test to wait for 1 retry window test period before declaring failure. Signed-off-by: Donald Sharp --- diff --git a/tests/topotests/lib/bgp.py b/tests/topotests/lib/bgp.py index c47dddb8d4..c05e14a95e 100644 --- a/tests/topotests/lib/bgp.py +++ b/tests/topotests/lib/bgp.py @@ -864,7 +864,7 @@ def clear_bgp_and_verify(tgen, topo, router): peer_uptime_before_clear_bgp = {} # Verifying BGP convergence before bgp clear command - for retry in range(1, 11): + for retry in range(31): sleeptime = 3 # Waiting for BGP to converge logger.info("Waiting for %s sec for BGP to converge on router" @@ -944,7 +944,7 @@ def clear_bgp_and_verify(tgen, topo, router): peer_uptime_after_clear_bgp = {} # Verifying BGP convergence after bgp clear command - for retry in range(11): + for retry in range(31): sleeptime = 3 # Waiting for BGP to converge logger.info("Waiting for %s sec for BGP to converge on router"