From: Louis Scalbert <louis.scalbert@6wind.com>
Date: Fri, 30 Aug 2024 12:14:17 +0000 (+0200)
Subject: tests: simplify nhrp_redundancy convergence
X-Git-Tag: docker/10.1.1~6^2~6
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=dbd888cce6665631a3db1f45ab5d084159878172;p=mirror%2Ffrr.git

tests: simplify nhrp_redundancy convergence

Simplify nhrp_redundancy convergence code. Cosmetic change.

Signed-off-by: Louis Scalbert <louis.scalbert@6wind.com>
---

diff --git a/tests/topotests/nhrp_redundancy/test_nhrp_redundancy.py b/tests/topotests/nhrp_redundancy/test_nhrp_redundancy.py
index 606df0e133..891a3cb8c3 100644
--- a/tests/topotests/nhrp_redundancy/test_nhrp_redundancy.py
+++ b/tests/topotests/nhrp_redundancy/test_nhrp_redundancy.py
@@ -10,7 +10,6 @@
 import os
 import sys
 import json
-from time import sleep
 from functools import partial
 import pytest
 
@@ -196,17 +195,15 @@ def test_protocols_convergence():
     if tgen.routers_have_failure():
         pytest.skip(tgen.errors)
 
-    logger.info("Checking NHRP cache and IPv4 routes for convergence")
+    logger.info("Checking NHRP cache for convergence")
     router_list = tgen.routers()
 
     # Check NHRP cache on servers and clients
     for rname, router in router_list.items():
-
-        json_file = "{}/{}/nhrp_cache.json".format(CWD, router.name)
-        if not os.path.isfile(json_file):
-            logger.info("skipping file {}".format(json_file))
+        if 'nh' not in rname:
             continue
 
+        json_file = "{}/{}/nhrp_cache.json".format(CWD, router.name)
         expected = json.loads(open(json_file).read())
         test_func = partial(
             topotest.router_json_cmp, router, "show ip nhrp cache json", expected
@@ -220,13 +217,12 @@ def test_protocols_convergence():
         assert result is None, assertmsg
 
     # Check NHRP IPV4 routes on servers and clients
+    logger.info("Checking IPv4 routes for convergence")
     for rname, router in router_list.items():
-
-        json_file = "{}/{}/nhrp_route.json".format(CWD, router.name)
-        if not os.path.isfile(json_file):
-            logger.info("skipping file {}".format(json_file))
+        if 'nh' not in rname:
             continue
 
+        json_file = "{}/{}/nhrp_route.json".format(CWD, router.name)
         expected = json.loads(open(json_file).read())
         test_func = partial(
             topotest.router_json_cmp, router, "show ip route nhrp json", expected