From: Paul Jakma Date: Mon, 27 Oct 2014 15:14:06 +0000 (+0000) Subject: HACKING: Use space char for indentation. X-Git-Tag: frr-2.0-rc1~738 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=db5a0ac1107ab3989f49b9b72188a171a7c19b4c;p=mirror%2Ffrr.git HACKING: Use space char for indentation. * HACKING.tex: Whitespace/indent section is probably out of date. Rephrase. Remove the editor recommendations, as I don't know what would be correct. Acked-by: Vincent Jardin (cherry picked from commit 4da670b7a9aacf552aa11c4d4f6d994b312ada89) --- diff --git a/HACKING.tex b/HACKING.tex index 57235b1602..be86ae18d2 100644 --- a/HACKING.tex +++ b/HACKING.tex @@ -21,23 +21,12 @@ are welcome. GNU coding standards apply. Indentation follows the result of -invoking GNU indent (as of 2.2.8a) with no arguments. Note that this -uses tabs instead of spaces where possible for leading whitespace, and -assumes that tabs are every 8 columns. Do not attempt to redefine the -location of tab stops. Note also that some indentation does not -follow GNU style. This is a historical accident, and we generally -only clean up whitespace when code is unmaintainable due to whitespace -issues, to minimise merging conflicts. - -For GNU emacs, use indentation style ``gnu''. - -For Vim, use the following lines (note that tabs are at 8, and that -softtabstop sets the indentation level): - -set tabstop=8 -set softtabstop=2 -set shiftwidth=2 -set noexpandtab +invoking GNU indent (as of 2.2.8a) with the --nut argument. + +Originally, tabs were used instead of spaces, with tabs are every 8 columns. +However, tab's interoperability issues mean space characters are now preferred for +new changes. We generally only clean up whitespace when code is unmaintainable +due to whitespace issues, to minimise merging conflicts. Be particularly careful not to break platforms/protocols that you cannot test.