From: Donald Sharp <sharpd@nvidia.com>
Date: Sun, 10 Sep 2023 13:17:20 +0000 (-0400)
Subject: bgpd: bgp_evpn_mh_route_delete should ensure dest is still usable
X-Git-Tag: base_9.1~77^2~19
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=dade8dfdd69add9a051723ea26547cfcddb4ac14;p=matthieu%2Ffrr.git

bgpd: bgp_evpn_mh_route_delete should ensure dest is still usable

Again coverity believes that dest may be freed but it should not
be because of how locking is done.  Make coverity happy.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
---

diff --git a/bgpd/bgp_evpn_mh.c b/bgpd/bgp_evpn_mh.c
index 91db9a061a..7700281cd2 100644
--- a/bgpd/bgp_evpn_mh.c
+++ b/bgpd/bgp_evpn_mh.c
@@ -513,8 +513,11 @@ static int bgp_evpn_mh_route_delete(struct bgp *bgp, struct bgp_evpn_es *es,
 	 */
 	delete_evpn_route_entry(bgp, afi, safi, dest, &pi);
 	if (pi)
-		bgp_path_info_reap(dest, pi);
+		dest = bgp_path_info_reap(dest, pi);
+
+	assert(dest);
 	bgp_dest_unlock_node(dest);
+
 	return 0;
 }