From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Tue, 16 Oct 2018 21:26:21 +0000 (-0400)
Subject: bgpd: Add a better breadcrumb for interface based peers
X-Git-Tag: frr-7.1-dev~260^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=d762bcc370005b69f8230536e535f77f54a74c88;p=mirror%2Ffrr.git

bgpd: Add a better breadcrumb for interface based peers

If you are using bgp unnumbered( or interface based peers )
when we detect an error give the user a bit more of a clue
what they may have done wrong.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index 5af9f7e24c..c5d2993951 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -2740,7 +2740,8 @@ static int peer_remote_as_vty(struct vty *vty, const char *peer_str,
 			ret = peer_group_remote_as(bgp, peer_str, &as, as_type);
 			if (ret < 0) {
 				vty_out(vty,
-					"%% Create the peer-group or interface first\n");
+					"%% Create the peer-group or interface first or specify \"interface\" keyword\n");
+				vty_out(vty, "%% if using an unnumbered interface neighbor\n");
 				return CMD_WARNING_CONFIG_FAILED;
 			}
 			return CMD_SUCCESS;