From: nguggarigoud <nguggarigoud@vmware.com>
Date: Tue, 21 Jun 2022 07:42:45 +0000 (-0700)
Subject: tests: Removing invalid step from ospf tests.
X-Git-Tag: base_8.4~331^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=d5bd35543059b22e7c65d6a6c72fc4f6d3136873;p=mirror%2Ffrr.git

tests: Removing invalid step from ospf tests.

1. Removed the step from hello test case with hello
timer of 65535. This test works in some platforms
and does not work in others, affecting stability.

Signed-off-by: nguggarigoud <nguggarigoud@vmware.com>
---

diff --git a/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py b/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
index c7ee723b3e..21a7d83845 100644
--- a/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
+++ b/tests/topotests/ospf_basic_functionality/test_ospf_single_area.py
@@ -596,93 +596,6 @@ def test_ospf_hello_tc10_p0(request):
         ospf_covergence
     )
 
-    step(" Configure hello timer = 65535")
-    topo1 = {
-        "r0": {
-            "links": {
-                "r1": {
-                    "interface": topo["routers"]["r0"]["links"]["r1"]["interface"],
-                    "ospf": {"hello_interval": 65535, "dead_interval": 4},
-                }
-            }
-        }
-    }
-
-    result = create_interfaces_cfg(tgen, topo1)
-    assert result is True, "Testcase {} : Failed \n Error: {}".format(tc_name, result)
-
-    topo1 = {
-        "r1": {
-            "links": {
-                "r0": {
-                    "interface": topo["routers"]["r1"]["links"]["r0"]["interface"],
-                    "ospf": {"hello_interval": 65535, "dead_interval": 4},
-                }
-            }
-        }
-    }
-
-    result = create_interfaces_cfg(tgen, topo1)
-    assert result is True, "Testcase {} : Failed \n Error: {}".format(tc_name, result)
-
-    step("verify that new timer value is configured.")
-    input_dict = {
-        "r0": {
-            "links": {"r1": {"ospf": {"timerMsecs": 65535 * 1000, "timerDeadSecs": 4}}}
-        }
-    }
-    dut = "r0"
-    result = verify_ospf_interface(tgen, topo, dut=dut, input_dict=input_dict)
-    assert result is True, "Testcase {} : Failed \n Error: {}".format(tc_name, result)
-
-    step("verify that ospf neighbours are  full")
-    ospf_covergence = verify_ospf_neighbor(tgen, topo, dut=dut)
-    assert ospf_covergence is True, "setup_module :Failed \n Error:" " {}".format(
-        ospf_covergence
-    )
-
-    step(" Try configuring timer values outside range for example 65536")
-    topo1 = {
-        "r0": {
-            "links": {
-                "r1": {
-                    "interface": topo["routers"]["r0"]["links"]["r1"]["interface"],
-                    "ospf": {"hello_interval": 65536, "dead_interval": 4},
-                }
-            }
-        }
-    }
-
-    result = create_interfaces_cfg(tgen, topo1)
-    assert result is not True, "Testcase {} : Failed \n Error: {}".format(
-        tc_name, result
-    )
-
-    step("Unconfigure the hello timer from the interface from r1 and r2.")
-
-    topo1 = {
-        "r1": {
-            "links": {
-                "r0": {
-                    "interface": topo["routers"]["r1"]["links"]["r0"]["interface"],
-                    "ospf": {"hello_interval": 65535},
-                    "delete": True,
-                }
-            }
-        }
-    }
-
-    result = create_interfaces_cfg(tgen, topo1)
-    assert result is True, "Testcase {} : Failed \n Error: {}".format(tc_name, result)
-
-    step(
-        "Verify that timer value is deleted from intf & " "set to default value 40 sec."
-    )
-    input_dict = {"r1": {"links": {"r0": {"ospf": {"timerMsecs": 10 * 1000}}}}}
-    dut = "r1"
-    result = verify_ospf_interface(tgen, topo, dut=dut, input_dict=input_dict)
-    assert result is True, "Testcase {} : Failed \n Error: {}".format(tc_name, result)
-
     write_test_footer(tc_name)