From: Don Slice <dslice@cumulusnetworks.com>
Date: Fri, 10 Jun 2016 13:58:03 +0000 (-0700)
Subject: bgpd: remove vrf->iflist deleted to avoid a crash
X-Git-Tag: frr-2.0-rc1~465^2~24
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=d236e0b80a40d57198ad661f085ac0e57489a86c;p=matthieu%2Ffrr.git

bgpd: remove vrf->iflist deleted to avoid a crash

Ticket: CM-11327
Signed-off-by: Don Slice
Reviewed-by: Donald Sharp
Testing Done: Manual testing, bgp-min, vrf-min, bgp-smoke, vrf-smoke all successful

When bgp was configured in a vrf and then deleted, the vrf->iflist
was being deleted from the vrf.  Since the vrf itself was not deleted,
it was assumed in later calls that the vrf->iflist was still there
and when it was referenced, the crash occurred.
---

diff --git a/bgpd/bgpd.c b/bgpd/bgpd.c
index ed76cfcf60..f23cc13725 100644
--- a/bgpd/bgpd.c
+++ b/bgpd/bgpd.c
@@ -7251,7 +7251,6 @@ bgp_if_finish (struct bgp *bgp)
       for (ALL_LIST_ELEMENTS (ifp->connected, c_node, c_nnode, c))
         bgp_connected_delete (bgp, c);
     }
-  vrf_iflist_terminate (bgp->vrf_id);
 }
 
 void