From: paul Date: Wed, 4 Jun 2003 02:28:45 +0000 (+0000) Subject: From: kamatchi soundaram X-Git-Tag: frr-2.0-rc1~4010 X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=cfc959b8f5f7ea1185fb3de2e4064704d62336f0;p=matthieu%2Ffrr.git From: kamatchi soundaram Subject: [zebra 19263] Another memory leak!! is zebra OSPF This memory leak gets into picture whenever any interface goes down. Problem found and desctription: Whenever the interface goes down, the "def_params" (member of ospf_if_info) structure memory is not freed. Fix made: added the following line to free the "def_params" memory of ospf_if_info before calling the "XFREE(MTYPE_OSPF_IF_INFO, ifp->info);" The added line is: ospf_del_if_params ((struct ospf_if_params *) IF_DEF_PARAMS (ifp)); --- diff --git a/ospfd/ospf_interface.c b/ospfd/ospf_interface.c index 83abf5538f..08bc7fbebc 100644 --- a/ospfd/ospf_interface.c +++ b/ospfd/ospf_interface.c @@ -643,6 +643,7 @@ ospf_if_delete_hook (struct interface *ifp) #endif /* HAVE_OPAQUE_LSA */ route_table_finish (IF_OIFS (ifp)); route_table_finish (IF_OIFS_PARAMS (ifp)); + ospf_del_if_params ((struct ospf_if_params *) IF_DEF_PARAMS (ifp)); XFREE (MTYPE_OSPF_IF_INFO, ifp->info); ifp->info = NULL;