From: Stefan Hanreich <s.hanreich@proxmox.com>
Date: Fri, 5 Apr 2024 13:17:56 +0000 (+0200)
Subject: sdn: dhcp: only consider subnets that have dhcp-range configured
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=c60a7dc4323f33b75c3128db950e3776d2a3942d;p=matthieu%2Fpve-network.git

sdn: dhcp: only consider subnets that have dhcp-range configured

If DHCP is enabled on a zone with subnets, but no subnet has a
dhcp-range configured, then starting a VM will fail because no IP can
be allocated. This patch fixes this by only considering subnets that
have a dhcp-range configured and only failing if there is at least one
subnet with a dhcp-range configured.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Reviewed-by: Stefan Lendl <s.lendl@proxmox.com>
Tested-by: Stefan Lendl <s.lendl@proxmox.com>
Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
---

diff --git a/src/PVE/Network/SDN/Vnets.pm b/src/PVE/Network/SDN/Vnets.pm
index 4542b70..cbf0a07 100644
--- a/src/PVE/Network/SDN/Vnets.pm
+++ b/src/PVE/Network/SDN/Vnets.pm
@@ -118,6 +118,7 @@ sub add_next_free_cidr {
 	    my $network = $subnet->{network};
 
 	    next if Net::IP::ip_get_version($network) != $ipversion || $ips->{$ipversion};
+	    next if !$subnet->{'dhcp-range'};
 	    $subnetcount++;
 
 	    eval {