From: F. Aragon <paco@voltanet.io>
Date: Mon, 2 Jul 2018 15:37:23 +0000 (+0200)
Subject: nhrpd: odd operator usage fix (PVS-Studio)
X-Git-Tag: frr-6.1-dev~205^2
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=c4822682d15f6caa62406b416ac47be6d9434756;p=matthieu%2Ffrr.git

nhrpd: odd operator usage fix (PVS-Studio)

Signed-off-by: F. Aragon <paco@voltanet.io>
---

diff --git a/nhrpd/nhrp_packet.c b/nhrpd/nhrp_packet.c
index c27ebe1d90..e62ee1ef72 100644
--- a/nhrpd/nhrp_packet.c
+++ b/nhrpd/nhrp_packet.c
@@ -164,7 +164,7 @@ struct nhrp_cie_header *nhrp_cie_pull(struct zbuf *zb,
 	if (!cie)
 		return NULL;
 
-	if (cie->nbma_address_len + cie->nbma_subaddress_len) {
+	if (cie->nbma_address_len + cie->nbma_subaddress_len > 0) {
 		sockunion_set(nbma, afi2family(htons(hdr->afnum)),
 			      zbuf_pulln(zb,
 					 cie->nbma_address_len