From: Philippe Guibert <philippe.guibert@6wind.com>
Date: Thu, 9 Feb 2017 08:09:54 +0000 (+0100)
Subject: bgpd: fix overlay index comparison
X-Git-Tag: frr-3.0-branchpoint~29^2~9
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=c298dae25906c33d61f86235c39380212f48a138;p=matthieu%2Ffrr.git

bgpd: fix overlay index comparison

To know if overlay index is the same between two route information,
then the two overlay index field is compared. If both fields are set to
null, then the comparison should be equal, then return true, which was
not done.

Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
---

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 3a3cefda59..929a9fb4ad 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -429,7 +429,7 @@ overlay_index_same(const struct attr_extra *ae1, const struct attr_extra *ae2)
   if(!ae2 && ae1)
     return false;
   if(!ae1 && !ae2)
-    return false;
+    return true;
   return !memcmp(&(ae1->evpn_overlay), &(ae2->evpn_overlay), sizeof(struct overlay_index));
 }