From: Ulrich Weber <ulrich.weber@sophos.com>
Date: Thu, 17 Nov 2011 17:35:08 +0000 (+0400)
Subject: ripngd: limit max of "timers basic" to 65535 as documented
X-Git-Tag: frr-2.0-rc1~1918^2~37
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=c0cad4368858d24caedd7e7d2bb776b6d4dd6eb3;p=mirror%2Ffrr.git

ripngd: limit max of "timers basic" to 65535 as documented

and use VTY_GET_INTEGER_RANGE instead of calling strtoul
---

diff --git a/ripngd/ripngd.c b/ripngd/ripngd.c
index d416255c2f..8e97c2f8ba 100644
--- a/ripngd/ripngd.c
+++ b/ripngd/ripngd.c
@@ -2485,28 +2485,10 @@ DEFUN (ripng_timers,
   unsigned long update;
   unsigned long timeout;
   unsigned long garbage;
-  char *endptr = NULL;
 
-  update = strtoul (argv[0], &endptr, 10);
-  if (update == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "update timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
-  
-  timeout = strtoul (argv[1], &endptr, 10);
-  if (timeout == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "timeout timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
-  
-  garbage = strtoul (argv[2], &endptr, 10);
-  if (garbage == ULONG_MAX || *endptr != '\0')
-    {
-      vty_out (vty, "garbage timer value error%s", VTY_NEWLINE);
-      return CMD_WARNING;
-    }
+  VTY_GET_INTEGER_RANGE("update timer", update, argv[0], 0, 65535);
+  VTY_GET_INTEGER_RANGE("timeout timer", timeout, argv[1], 0, 65535);
+  VTY_GET_INTEGER_RANGE("garbage timer", garbage, argv[2], 0, 65535);
 
   /* Set each timer value. */
   ripng->update_time = update;