From: Quentin Young <qlyoung@cumulusnetworks.com>
Date: Wed, 23 Jan 2019 22:30:02 +0000 (+0000)
Subject: vrrpd: fix a few bad XFREEs
X-Git-Tag: base_7.2~330^2~125
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=b79640e4b06b7c4e3e8a45d4029113fb8ba91a28;p=matthieu%2Ffrr.git

vrrpd: fix a few bad XFREEs

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
---

diff --git a/vrrpd/vrrp.c b/vrrpd/vrrp.c
index fcc1cec51c..94f59f37ff 100644
--- a/vrrpd/vrrp.c
+++ b/vrrpd/vrrp.c
@@ -232,7 +232,8 @@ static struct vrrp_router *vrrp_router_create(struct vrrp_vrouter *vr,
 		}
 	}
 
-	XFREE(MTYPE_TMP, ifps);
+	if (ifps_cnt)
+		XFREE(MTYPE_TMP, ifps);
 
 	char ethstr[ETHER_ADDR_STRLEN];
 	prefix_mac2str(&r->vmac, ethstr, sizeof(ethstr));
@@ -505,8 +506,6 @@ static int vrrp_read(struct thread *thread)
 		vrrp_recv_advertisement(r, pkt, pktsize);
 	}
 
-	XFREE(MTYPE_TMP, pkt);
-
 	resched = true;
 
 done: