From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Tue, 24 Sep 2019 23:34:39 +0000 (-0400)
Subject: isisd: circuit is derefed in every code path
X-Git-Tag: base_7.3~307^2~3
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=b53c5f1ab47d05a85b254e88f12be4ac5c71d42a;p=matthieu%2Ffrr.git

isisd: circuit is derefed in every code path

No need to check for circuit being null, we have
already de-refed it in every code path and
would have crashed before this point if it was.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/isisd/isis_te.c b/isisd/isis_te.c
index 44fa45d02b..9871d2bcb9 100644
--- a/isisd/isis_te.c
+++ b/isisd/isis_te.c
@@ -81,8 +81,7 @@ void isis_link_params_update(struct isis_circuit *circuit,
 		return;
 
 	/* Sanity Check */
-	if ((circuit == NULL) || (ifp == NULL)
-	    || (circuit->state != C_STATE_UP))
+	if ((ifp == NULL) || (circuit->state != C_STATE_UP))
 		return;
 
 	zlog_debug("TE(%s): Update circuit parameters for interface %s",