From: Martin Winter <mwinter@opensourcerouting.org>
Date: Fri, 3 Feb 2017 11:37:48 +0000 (+0700)
Subject: lib: CID 1399296: Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)
X-Git-Tag: frr-2.0-rc2~5^2~1
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=b3411578b063894892d469dfda8cad02a2ecd0ed;p=mirror%2Ffrr.git

lib: CID 1399296: Assign instead of compare (PW.ASSIGN_WHERE_COMPARE_MEANT)

Needs to be a comparison, not assignment

Signed-off-by: Martin Winter <mwinter@opensourcerouting.org>
---

diff --git a/lib/thread.c b/lib/thread.c
index 5b8778b717..e10d0c48bf 100644
--- a/lib/thread.c
+++ b/lib/thread.c
@@ -828,7 +828,7 @@ funcname_thread_add_read_write (int dir, struct thread_master *m,
 #else
   if (FD_ISSET (fd, fdset))
     {
-      zlog (NULL, LOG_WARNING, "There is already %s fd [%d]", (dir = THREAD_READ) ? "read" : "write", fd);
+      zlog (NULL, LOG_WARNING, "There is already %s fd [%d]", (dir == THREAD_READ) ? "read" : "write", fd);
       return NULL;
     }