From: Donald Sharp <sharpd@cumulusnetworks.com>
Date: Thu, 16 Nov 2017 18:10:41 +0000 (-0500)
Subject: zebra: Note about functionality in rt.h
X-Git-Tag: frr-4.0-dev~147^2~3
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=b33803d74a9d53bf1837ef28a22cab4893c09379;p=matthieu%2Ffrr.git

zebra: Note about functionality in rt.h

When we are modifying the kernel there could
be multiple modules/hooks involved in this
process.  As such let the caller set
the appropriate flags for success/failure.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
---

diff --git a/zebra/rt.h b/zebra/rt.h
index f5f0fa195b..3ce15e9640 100644
--- a/zebra/rt.h
+++ b/zebra/rt.h
@@ -30,6 +30,17 @@
 #include "zebra/zebra_ns.h"
 #include "zebra/zebra_mpls.h"
 
+/*
+ * Philosophy Note:
+ *
+ * Flags being SET/UNSET do not belong in the South Bound
+ * Interface.  This Setting belongs at the calling level
+ * because we can and will have multiple different interfaces
+ * and we will have potentially multiple different
+ * modules/filters to call.  As such Setting/Unsetting
+ * success failure should be handled by the caller.
+ */
+
 extern int kernel_route_rib(struct prefix *, struct prefix *,
 			    struct route_entry *, struct route_entry *);