From: Donald Sharp <sharpd@cumulusnetwroks.com>
Date: Sun, 15 May 2016 17:31:30 +0000 (-0400)
Subject: bgpd: Fix more clang compiler warnings
X-Git-Tag: frr-2.0-rc1~895
X-Git-Url: https://git.puffer.fish/?a=commitdiff_plain;h=b0689168486e8446e681d984e2230da23b942fca;p=mirror%2Ffrr.git

bgpd: Fix more clang compiler warnings

Remove some dead code and fix initialization of the
sockunion.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
Reviewed-by: Daniel Walton <dwalton@cumulusnetworks.com>
---

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index d37fa1e79a..366b105f22 100644
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -74,7 +74,6 @@ static const struct message attr_flag_str[] =
   /* bgp_attr_flags_diagnose() relies on this bit being last in this list */
   { BGP_ATTR_FLAG_EXTLEN,   "Extended Length" },
 };
-static const size_t attr_flag_str_max = array_size(attr_flag_str);
 
 static struct hash *cluster_hash;
 
diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index 48cdd518dd..90f4cfe8b1 100644
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -118,8 +118,8 @@ route_match_peer (void *rule, struct prefix *prefix, route_map_object_t type,
       void *object)
 {
   union sockunion *su;
-  union sockunion su_def = { .sa.sa_family = AF_INET,
-			     .sin.sin_addr.s_addr = INADDR_ANY };
+  union sockunion su_def = { .sin.sin_family = AF_INET,
+                             .sin.sin_addr.s_addr = INADDR_ANY };
   struct peer_group *group;
   struct peer *peer;
   struct listnode *node, *nnode;